This repository was archived by the owner on Oct 15, 2020. It is now read-only.
tools: add chakra_tdd.h to install.py#421
Closed
joaocgreis wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
chakra_tdd.h was added to the sources. This adds it to install.py to be included in the headers package. Refs: nodejs#397 Fixes: nodejs#417
Member
Author
gireeshpunathil
approved these changes
Nov 2, 2017
Member
gireeshpunathil
left a comment
gireeshpunathil
left a comment
There was a problem hiding this comment.
how about following the single line custom for single file inclusions? (for example L174 and L194)
mike-kaufman
approved these changes
Nov 2, 2017
Member
Author
|
Updated, single line sounds good for now. |
joaocgreis
added a commit
that referenced
this pull request
Nov 9, 2017
chakra_tdd.h was added to the sources. This adds it to install.py to be included in the headers package. Refs: #397 Fixes: #417 PR-URL: #421 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Mike Kaufman <[email protected]>
Member
Author
|
Landed in fca1d9f |
kfarnung
pushed a commit
that referenced
this pull request
Jan 12, 2018
chakra_tdd.h was added to the sources. This adds it to install.py to be included in the headers package. Refs: #397 Fixes: #417 PR-URL: #421 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Mike Kaufman <[email protected]>
chakrabot
pushed a commit
that referenced
this pull request
Mar 21, 2018
[MERGE #4832 @jackhorton] Update PlatformAgnostic case conversion functions to allow expanding-length strings Merge pull request #4832 from jackhorton:icu/tocase Fixes #421 Fixes #4526 Also fixes a previously untracked? bug where String.prototype.toLocale{Upper|Lower}Case.call(null) would print Reviewed-By: chakrabot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chakra_tdd.hwas added to the sources in #397. This adds it to install.py to be included in the headers package.Refs: #397
Fixes: #417
cc @mike-kaufman @mrkmarron
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools