This repository was archived by the owner on Oct 15, 2020. It is now read-only.
test: fixing test_general to work with imprecise GC#406
Merged
MSLaguana merged 1 commit intonodejs:masterfrom Sep 29, 2017
Merged
test: fixing test_general to work with imprecise GC#406MSLaguana merged 1 commit intonodejs:masterfrom
MSLaguana merged 1 commit intonodejs:masterfrom
Conversation
jackhorton
approved these changes
Sep 29, 2017
digitalinfinity
approved these changes
Sep 29, 2017
PR-URL: ndoejs/node-chakracore#406 Reviewed-By: Jack Horton <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weak reference problem of #380 has been addressed upstream in the test which will no longer expect to take a weak reference to non-objects. The test was still failing due to an object not being GCd when the test expected it to. There was an interpreter frame which was keeping the object alive, so the GC didn't clean up the object. By encapsulating it in a function we ensure that when we GC there is no lingering reference.
fixes #380
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test