Fix for build break in PR #194. #199
Conversation
|
LGTM. Why is this a problem only in Ubuntu and not Windows/macOs? |
|
@kunalspathak @joaocgreis Did I trigger the CI incorrectly? I see failures here that cor.h is not available while compiling ChakraCore- https://ci.nodejs.org/job/node-compile-windows/label=win-vcbt2015/7765/console |
|
vcbt flavor is expected to fail. There was an issue opened by @joaocgreis , but I can't find it right now. As long as other flavors pass, it should be good. Also, the CI doesn't have Ubuntu verification and this fix needs Ubuntu testing. At this point, I would just manually make sure that there are no build/test failures on Ubuntu with this Pr. |
Fixes: nodejs#194 PR-URL: nodejs#199 Reviewed-By: Hitesh Kanwathirtha <[email protected]>
|
Reopened VCBT issue: #200 (user account that was used to upen it was deleted, and GitHub silently deleted the issue as well). |
4 participants
make -j4 test(UNIX), orvcbuild test(Windows) passesDescription of change
Fix for build break in PR #194 -- issue ##195
PR-URL: mrkmarron@fafa155