Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit c35ccd2

Browse files
committed
chakrashim: Added missing API in v8.h
1 parent 0091e49 commit c35ccd2

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

deps/chakrashim/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#define V8_MAJOR_VERSION 5
3535
#define V8_MINOR_VERSION 1
3636
#define V8_BUILD_NUMBER 281
37-
#define V8_PATCH_LEVEL 69
37+
#define V8_PATCH_LEVEL 80
3838

3939
// Use 1 for candidates and 0 otherwise.
4040
// (Boolean macro values are not supported by all preprocessors.)

deps/chakrashim/include/v8.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1603,6 +1603,8 @@ class PropertyCallbackInfo {
16031603
Local<Value> Data() const { return _data; }
16041604
Local<Object> This() const { return _thisObject; }
16051605
Local<Object> Holder() const { return _holder; }
1606+
// CHAKRA-TODO
1607+
bool ShouldThrowOnError() const { return true; }
16061608
ReturnValue<T> GetReturnValue() const {
16071609
return ReturnValue<T>(
16081610
&(const_cast<PropertyCallbackInfo<T>*>(this)->_returnValue));

test/parallel/test-repl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ function error_test() {
389389
// Avoid emitting stack trace
390390
{ client: client_unix, send: 'a = 3.5e',
391391
expect: /^(?!\s+at\s)/gm },
392-
].filter((v) => !common.engineSpecificMessage(v)));
392+
].filter((v) => !common.engineSpecificMessage(v)));
393393
}
394394

395395
function tcp_test() {

0 commit comments

Comments
 (0)