chakrashim,src: fix build breaks

kfarnung · kfarnung · commit 46966a3ffbb7 · 2018-04-18T13:42:43.000-07:00
* Add new shimmed APIs
* Remove fail fasts for unimplemented tracing methods
* Update startup code for signature changes
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -1132,6 +1132,7 @@ class V8_EXPORT Value : public Data {
   bool IsWeakSet() const;
   bool IsPromise() const;
   bool IsProxy() const;
+  bool IsModuleNamespaceObject() const;
 
   V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(
     Local<Context> context) const;
diff --git a/deps/chakrashim/lib/chakra_shim.js b/deps/chakrashim/lib/chakra_shim.js
@@ -606,6 +606,10 @@
       return compareType(obj, 'SharedArrayBuffer');
     };
 
+    utils.isModuleNamespaceObject = function(obj) {
+      return compareType(obj, 'Module');
+    };
+
     utils.getSymbolKeyFor = function(symbol) {
       return Symbol_keyFor(symbol);
     };
diff --git a/deps/chakrashim/src/jsrtcachedpropertyidref.inc b/deps/chakrashim/src/jsrtcachedpropertyidref.inc
@@ -162,6 +162,7 @@ DEF_IS_TYPE(isWeakSet)
 DEF_IS_TYPE(isSymbolObject)
 DEF_IS_TYPE(isName)
 DEF_IS_TYPE(isSharedArrayBuffer)
+DEF_IS_TYPE(isModuleNamespaceObject)
 
 
 #undef DEF
diff --git a/deps/chakrashim/src/v8v8.cc b/deps/chakrashim/src/v8v8.cc
@@ -226,28 +226,24 @@ namespace platform {
   void SetTracingController(
       v8::Platform* platform,
       v8::platform::tracing::TracingController* tracing_controller) {
-    jsrt::Unimplemented("TracingController");
   }
 }  // namespace platform
 
 namespace platform {
 namespace tracing {
   void TracingController::StopTracing() {
-    jsrt::Unimplemented("TracingController");
   }
 
   void TracingController::StartTracing(TraceConfig*) {
-    jsrt::Unimplemented("TracingController");
   }
 
   void TracingController::Initialize(TraceBuffer*) {
-    jsrt::Unimplemented("TracingController");
   }
 
   const uint8_t* TracingController::GetCategoryGroupEnabled(
       const char* category_group) {
-    jsrt::Unimplemented("TracingController");
-    return nullptr;
+    static uint8_t no = 0;
+    return &no;
   }
 
   uint64_t TracingController::AddTraceEvent(
@@ -257,17 +253,14 @@ namespace tracing {
       const uint64_t* arg_values,
       std::unique_ptr<v8::ConvertableToTraceFormat>* arg_convertables,
       unsigned int flags) {
-    jsrt::Unimplemented("TracingController");
     return 0;
   }
 
   void TracingController::UpdateTraceEventDuration(
       const uint8_t* category_enabled_flag, const char* name, uint64_t handle) {
-    jsrt::Unimplemented("TracingController");
   }
 
   int64_t TracingController::CurrentTimestampMicroseconds() {
-    jsrt::Unimplemented("TracingController");
     return 0;
   }
 
diff --git a/deps/chakrashim/src/v8value.cc b/deps/chakrashim/src/v8value.cc
@@ -180,6 +180,7 @@ IS_TYPE_FUNCTION(IsWeakSet, isWeakSet)
 IS_TYPE_FUNCTION(IsSymbolObject, isSymbolObject)
 IS_TYPE_FUNCTION(IsName, isName)
 IS_TYPE_FUNCTION(IsSharedArrayBuffer, isSharedArrayBuffer)
+IS_TYPE_FUNCTION(IsModuleNamespaceObject, isModuleNamespaceObject)
 
 MaybeLocal<Boolean> Value::ToBoolean(Local<Context> context) const {
   JsValueRef value;
diff --git a/src/node.cc b/src/node.cc

Original file line number	Diff line number	Diff line change
`@@ -226,28 +226,24 @@ namespace platform {`
`226`	`226`	`void SetTracingController(`
`227`	`227`	`v8::Platform* platform,`
`228`	`228`	`v8::platform::tracing::TracingController* tracing_controller) {`
`229`		`- jsrt::Unimplemented("TracingController");`
`230`	`229`	`}`
`231`	`230`	`} // namespace platform`
`232`	`231`
`233`	`232`	`namespace platform {`
`234`	`233`	`namespace tracing {`
`235`	`234`	`void TracingController::StopTracing() {`
`236`		`- jsrt::Unimplemented("TracingController");`
`237`	`235`	`}`
`238`	`236`
`239`	`237`	`void TracingController::StartTracing(TraceConfig*) {`
`240`		`- jsrt::Unimplemented("TracingController");`
`241`	`238`	`}`
`242`	`239`
`243`	`240`	`void TracingController::Initialize(TraceBuffer*) {`
`244`		`- jsrt::Unimplemented("TracingController");`
`245`	`241`	`}`
`246`	`242`
`247`	`243`	`const uint8_t* TracingController::GetCategoryGroupEnabled(`
`248`	`244`	`const char* category_group) {`
`249`		`- jsrt::Unimplemented("TracingController");`
`250`		`- return nullptr;`
	`245`	`+ static uint8_t no = 0;`
	`246`	`+ return &no;`
`251`	`247`	`}`
`252`	`248`
`253`	`249`	`uint64_t TracingController::AddTraceEvent(`
`@@ -257,17 +253,14 @@ namespace tracing {`
`257`	`253`	`const uint64_t* arg_values,`
`258`	`254`	`std::unique_ptr<v8::ConvertableToTraceFormat>* arg_convertables,`
`259`	`255`	`unsigned int flags) {`
`260`		`- jsrt::Unimplemented("TracingController");`
`261`	`256`	`return 0;`
`262`	`257`	`}`
`263`	`258`
`264`	`259`	`void TracingController::UpdateTraceEventDuration(`
`265`	`260`	`const uint8_t* category_enabled_flag, const char* name, uint64_t handle) {`
`266`		`- jsrt::Unimplemented("TracingController");`
`267`	`261`	`}`
`268`	`262`
`269`	`263`	`int64_t TracingController::CurrentTimestampMicroseconds() {`
`270`		`- jsrt::Unimplemented("TracingController");`
`271`	`264`	`return 0;`
`272`	`265`	`}`
`273`	`266`