You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 15, 2020. It is now read-only.
meta: merge node/master into node-chakracore/master
Merge 7b3446e as of 2017-11-11
This commit was automatically generated. For any problems, please contact jackhorton
Reviewed-By: Jack Horton <[email protected]>
Copy file name to clipboardExpand all lines: BUILDING.md
+5-3Lines changed: 5 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -197,9 +197,11 @@ Prerequisites:
197
197
*[Visual Studio 2015 Update 3](https://www.visualstudio.com/), all editions
198
198
including the Community edition (remember to select
199
199
"Common Tools for Visual C++ 2015" feature during installation).
200
-
*[Visual Studio 2017](https://www.visualstudio.com/downloads/), any edition (including the Build Tools SKU).
201
-
**Required Components:** "MSbuild", "VC++ 2017 v141 toolset" and at least one of the Windows SDKs.
202
-
*Note*: For "Windows 10 SDK (10.0.15063.0)" only the "Desktop C++ x86 and x64" flavor is required.
200
+
* The "Desktop development with C++" workload from
201
+
[Visual Studio 2017](https://www.visualstudio.com/downloads/) or the
[Git for Windows](http://git-scm.com/download/win) includes Git Bash
205
207
and tools which can be included in the global `PATH`.
5. If your commit introduces a breaking change (`semver-major`), it should
338
+
contain an explanation about the reason of the breaking change, which
339
+
situation would trigger the breaking change and what is the exact change.
340
+
341
+
Breaking changes will be listed in the wiki with the aim to make upgrading
342
+
easier. Please have a look at [Breaking Changes](https://github.com/nodejs/node/wiki/Breaking-changes-between-v4-LTS-and-v6-LTS)
343
+
for the level of detail that's suitable.
344
+
337
345
Sample complete commit message:
338
346
339
347
```txt
@@ -625,6 +633,7 @@ Focus first on the most significant aspects of the change:
625
633
1. Does this change make sense for Node.js?
626
634
2. Does this change make Node.js better, even if only incrementally?
627
635
3. Are there clear bugs or larger scale issues that need attending to?
636
+
4. Is the commit message readable and correct? If it contains a breaking change is it clear enough?
628
637
629
638
When changes are necessary, *request* them, do not *demand* them, and do not
630
639
assume that the submitter already knows how to add a test or run a benchmark.
0 commit comments