v4: fix building v8 on libc++ 3.8.0 #9763
Conversation
nodejs-github-bot
added
v4.x
v8 engine
|
(I've disabled the nodejs 4.x/freebsd 11 skip) |
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM but you should bump the patch level in v8-version.h.
jbergstroem
force-pushed
the
fix/4.x-freebsd11
branch
from
700969f to
5832816
Compare
|
V8: CI will land if green /cc @nodejs/v8 to ensure this is ok to float... as the version of V8 on v4.x is unmaintained I can't think of a better way to do this |
|
I think rebase is required as the base branch is switched to |
|
For posterity, upstream has this fix in v8/v8@96cb90983 (partially). |
|
@ofrobots: cool, thanks for bringing it upstream! |
|
@jbergstroem to be clear, I didn't bring it upstream. Relevant upstream branches (other than the one corresponding to v4.x) already had the fix. |
Make sure the map allocators are of the same type. This fixes building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11). Upstream bug/patch: https://bugs.freebsd.org/208467
MylesBorins
force-pushed
the
fix/4.x-freebsd11
branch
from
5832816 to
01a78f4
Compare
|
I've gone ahead and rebased... one more go at CI |
Make sure the map allocators are of the same type. This fixes building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11). Upstream bug/patch: https://bugs.freebsd.org/208467 PR-URL: #9763 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
|
the failures on the v8 CI are appearing on v4.6.2, unrelated to this change. Landed in c1effb1 |
Make sure the map allocators are of the same type. This fixes building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11). Upstream bug/patch: https://bugs.freebsd.org/208467 PR-URL: nodejs/node#9763 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
6 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
deps/v8
Description of change
Make sure the map allocators are of the same type. This fixes building Node.js 4.x on libc++ 3.8.0 (for instance FreeBSD 11).
Upstream bug/patch: https://bugs.freebsd.org/208467
/cc @thealphanerd