vm: name anonymous functions#9388
Closed
solebox wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
lpinca
reviewed
Nov 1, 2016
| Script.prototype.runInThisContext = function(options) { | ||
| if (options && options.breakOnSigint) { | ||
| return sigintHandlersWrap(() => { | ||
| const sigintHandler = () => { |
Member
There was a problem hiding this comment.
If line length is below 80 chars I think it is ok to put the whole function expression on one line.
Member
There was a problem hiding this comment.
I am a bit 😕 about the name here… this function does not handle any kind of signal; it’s the exact opposite, the function is run undisturbed by SIGINTs. (The comment/code for sigintHandlersWrap has a bit more information.) So maybe you could call it realRunInThisContext or runScriptUninterruped or something like that?
Contributor
Author
There was a problem hiding this comment.
where is the doc you are referring to , i want to understand this a little better
jasnell
approved these changes
Nov 2, 2016
Member
|
Going to land if no one objects. |
benjamingr
pushed a commit
that referenced
this pull request
Nov 6, 2016
Name anonymous arrow function in vm module to improve readability PR-URL: #9388 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Ref: #8913
Member
|
Landed in 5079763 Thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Nov 7, 2016
Name anonymous arrow function in vm module to improve readability PR-URL: #9388 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Ref: #8913
MylesBorins
added
the
baking-for-lts
3 tasks
Member
|
#10816 should land at the same time as this. |
MylesBorins
added
dont-land-on-v6.x
and removed
baking-for-lts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
vm
Description of change
named arrow function handlers :)
Ref: #8913