Skip to content

doc: add ctc-review label information#9072

Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Trott:ctc-review
Closed

doc: add ctc-review label information#9072
Trott wants to merge 2 commits intonodejs:masterfrom
Trott:ctc-review

Conversation

@Trott
Copy link
Copy Markdown
Member

@Trott Trott commented Oct 13, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

This documents use of the ctc-review label.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Oct 13, 2016
bnoordhuis
bnoordhuis approved these changes Oct 13, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with spelling nit.

Comment thread GOVERNANCE.md Outdated
by the CTC by logging a GitHub issue. Any Collaborator, CTC member, or the
moderator can bring the issue to the CTC's attention by applying the
`ctc-review` label. If consensus-seeking among CTC members fails for a
particular issue, it mae be added to the CTC meeting agenda by adding the
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Oct 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/mae/may/

@Fishrock123
Copy link
Copy Markdown
Contributor

Fishrock123 commented Oct 13, 2016

I think we should change the label to be closer in color to ctc-agenda -- thoughts?

jasnell
jasnell approved these changes Oct 13, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChALkeR ChALkeR mentioned this pull request Oct 13, 2016
Closed
@Trott
Copy link
Copy Markdown
Member Author

Trott commented Oct 13, 2016

I think we should change the label to be closer in color to ctc-agenda -- thoughts?

No opinion either way from me. I say go for it.
https://help.github.com/articles/creating-and-editing-labels-for-issues-and-pull-requests/

@Trott
Copy link
Copy Markdown
Member Author

Trott commented Oct 14, 2016

@nodejs/ctc

ofrobots
ofrobots approved these changes Oct 14, 2016
View reviewed changes
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott mentioned this pull request Oct 17, 2016
Closed
@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
addaleax
addaleax approved these changes Oct 19, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@MylesBorins
Copy link
Copy Markdown
Contributor

MylesBorins commented Oct 19, 2016

LGTM

On Wed, Oct 19, 2016, 12:30 PM Anna Henningsen [email protected]
wrote:

@addaleax approved this pull request.

SGTM

—
You are receiving this because you are on a team that was mentioned.

Reply to this email directly, view it on GitHub
#9072 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV20txRdkGNhdzePBxfaq5lTfgEepks5q1f9agaJpZM4KVezv
.

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Oct 19, 2016

lgtm

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Oct 19, 2016

LGTM

@jasnell jasnell self-assigned this Oct 19, 2016
jasnell pushed a commit that referenced this pull request Oct 19, 2016
@Trott @jasnell
doc: add ctc-review label information
add8854 
PR-URL: #9072
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Oct 19, 2016

Landed in add8854

@jasnell jasnell closed this Oct 19, 2016
jasnell pushed a commit that referenced this pull request Oct 20, 2016
@Trott @jasnell
doc: add ctc-review label information
89b920f 
PR-URL: #9072
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
@Trott
doc: add ctc-review label information
6c9a84b 
PR-URL: #9072
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
@Trott
doc: add ctc-review label information
e564cb6 
PR-URL: #9072
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
This was referenced Nov 22, 2016
Merged
Merged
@ChALkeR ChALkeR mentioned this pull request Feb 12, 2017
Closed
@Trott Trott deleted the ctc-review branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

+2 more reviewers

@ofrobots ofrobots ofrobots approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jasnell jasnell

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.