util: pretty-print SIMD types#6917
Merged
bnoordhuis merged 1 commit intonodejs:masterfrom May 23, 2016
Merged
Conversation
Contributor
|
Cool. LGTM. |
Member
|
LGTM |
Member
Author
|
New run because of CI funkiness: https://ci.nodejs.org/job/node-test-pull-request/2738/ |
Before:
Bool32x4 {}
Float32x4 {}
Int32x4 {}
// etc.
After:
Bool32x4 [ false, false, false, false ]
Float32x4 [ NaN, NaN, NaN, NaN ]
Int32x4 [ 0, 0, 0, 0 ]
// etc.
PR-URL: nodejs#6917
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
bnoordhuis
force-pushed
the
pretty-print-simd
branch
from
0c681e9 to
ee8e7cd
Compare
Member
Author
|
|
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
Before:
Bool32x4 {}
Float32x4 {}
Int32x4 {}
// etc.
After:
Bool32x4 [ false, false, false, false ]
Float32x4 [ NaN, NaN, NaN, NaN ]
Int32x4 [ 0, 0, 0, 0 ]
// etc.
PR-URL: #6917
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Before:
Bool32x4 {}
Float32x4 {}
Int32x4 {}
// etc.
After:
Bool32x4 [ false, false, false, false ]
Float32x4 [ NaN, NaN, NaN, NaN ]
Int32x4 [ 0, 0, 0, 0 ]
// etc.
PR-URL: #6917
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
CI: https://ci.nodejs.org/job/node-test-pull-request/2724/