test,win: skip addons/load-long-path on WOW64#6675
Closed
orangemocha wants to merge 0 commit intonodejs:masterfrom
Closed
test,win: skip addons/load-long-path on WOW64#6675orangemocha wants to merge 0 commit intonodejs:masterfrom
orangemocha wants to merge 0 commit intonodejs:masterfrom
Conversation
Contributor
|
What kind of system is |
Member
|
LGTM although it's more commonly spelled as "WoW64", I think? @Fishrock123 Windows 32 bits on a Windows 64 bits host. |
Contributor
Author
|
I went with the official spelling by Microsoft, I can change it if you feel strongly about it. |
Member
|
No strong feelings. |
Contributor
Author
|
I'll wait for #6697 to land and adopt the new skip syntax. |
Member
|
@orangemocha #6697 has landed, you should be able to use the new syntax here. |
orangemocha
force-pushed
the
orangemocha-Node3667
branch
from
f1d5293 to
ec9f8f4
Compare
Contributor
Author
|
Updated, thanks! |
Contributor
|
LGTM |
Contributor
Author
|
I am confident that the CI failures on ARM are unrelated to this change. /cc @nodejs/testing https://ci.nodejs.org/job/node-test-binary-arm/2285/RUN_SUBSET=6,label=pi1-raspbian-wheezy/ Landing shortly. |
orangemocha
added a commit
that referenced
this pull request
May 27, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
orangemocha
force-pushed
the
orangemocha-Node3667
branch
from
ec9f8f4 to
6e2ae8a
Compare
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: nodejs#3667 PR-URL: nodejs#6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Member
|
@orangemocha could this be backported? Still seeing this on 4.4.7. |
orangemocha
added a commit
to JaneaSystems/node
that referenced
this pull request
Jul 5, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: nodejs#3667 PR-URL: nodejs#6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
2 tasks
Contributor
Author
orangemocha
added a commit
that referenced
this pull request
Jul 8, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
This test fails on WOW64 because of a bug in the OS, and there is no acceptable workaround. Ref: #3667 PR-URL: #6675 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test,win
Description of change
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable wokaround.
Ref: #3667