Skip to content

test: test commit for nodejs-github-bot#6674

Closed
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Fishrock123:github-bot-jenkins-status
Closed

test: test commit for nodejs-github-bot#6674
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Fishrock123:github-bot-jenkins-status

Conversation

@Fishrock123
Copy link
Copy Markdown
Contributor

@Fishrock123 Fishrock123 commented May 10, 2016

Do Not Merge

Tracking testing issue for nodejs/github-bot#35

Proxy Jenkins build status to GitHub statuses

Current status at nodejs/github-bot#35 (comment)

@Fishrock123 Fishrock123 added wip Issues and PRs that are still a work in progress. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels May 10, 2016
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 10, 2016
@Fishrock123 Fishrock123 removed the test Issues and PRs related to the tests. label May 10, 2016
@Fishrock123 Fishrock123 mentioned this pull request May 10, 2016
Merged
@phillipj
Copy link
Copy Markdown
Member

phillipj commented May 11, 2016 •
edited
Loading

@Fishrock123 @jbergstroem highfive (see below)

@jbergstroem
Copy link
Copy Markdown
Member

jbergstroem commented May 11, 2016

Ok, I'll add progress to more jobs. For now it will be pass/fail but I'll add as we move forward.

@jbergstroem
Copy link
Copy Markdown
Member

jbergstroem commented May 11, 2016

Also, I've added the boolean flag (default false) to test-pr and test-commit, meaning all jobs should inherit from it.

@Fishrock123
Copy link
Copy Markdown
Contributor Author

Fishrock123 commented May 11, 2016

Looks like the linter aborted here, @jbergstroem is it possible to make Jenkins send "build aborted" on abort rather than "errors found"?

@Fishrock123
Copy link
Copy Markdown
Contributor Author

Fishrock123 commented May 11, 2016

CI was https://ci.nodejs.org/job/node-test-pull-request/2576/

new CI: https://ci.nodejs.org/job/node-test-pull-request/2580/

@Fishrock123 Fishrock123 mentioned this pull request May 11, 2016
Closed
@Fishrock123
Copy link
Copy Markdown
Contributor Author

Fishrock123 commented May 11, 2016

@jbergstroem hmm, strange, it don't update on new CI? All the links seems to be linked to different runs too.

@phillipj
Copy link
Copy Markdown
Member

phillipj commented May 11, 2016

@Fishrock123 we've got some issues figuring out the correct SHA to provide to the bot, related to rebasing.

@Fishrock123
Copy link
Copy Markdown
Contributor Author

Fishrock123 commented May 11, 2016 •
edited
Loading

Testing with no rebasing: https://ci.nodejs.org/job/node-test-pull-request/2584/

edit: no dice, maybe it's disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. wip Issues and PRs that are still a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fishrock123 @phillipj @jbergstroem @nodejs-github-bot