Skip to content

test: fix recursive fs.watch error fixture - #65683

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-fs-watch-enoent-test
Closed

test: fix recursive fs.watch error fixture#65683
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-fs-watch-enoent-test

Conversation

@panva

@panva panva commented Aug 31, 2026

Copy link
Copy Markdown
Member

The test introduced in #65635 was invalidated by #65486, both landed independently. This fixes a consistent test failure on main.

@panva
test: fix recursive fs.watch error fixture
19db255 
Use a child directory so recursive watcher setup always creates a
second watch. Linux no longer watches regular files after the directory
watcher optimization.

Signed-off-by: Filip Skokan <[email protected]>
Assisted-by: Codex
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 31, 2026
@panva panva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76772/

@panva panva mentioned this pull request Aug 31, 2026
Merged
@MikeMcC399 MikeMcC399 mentioned this pull request Aug 31, 2026
Merged
@panva

panva commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

We've got enough passes from CI and fast track approvals to call this a fix.

panva added a commit that referenced this pull request Aug 31, 2026
@panva
test: fix recursive fs.watch error fixture
a844473 
Use a child directory so recursive watcher setup always creates a
second watch. Linux no longer watches regular files after the directory
watcher optimization.

Signed-off-by: Filip Skokan <[email protected]>
Assisted-by: Codex
PR-URL: #65683
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@panva

panva commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

Landed in a844473

@panva panva closed this Aug 31, 2026
@panva
panva deleted the fix-fs-watch-enoent-test branch August 31, 2026 15:49
@codecov

codecov Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (e68a93a) to head (19db255).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #65683   +/-   ##
=======================================
  Coverage   90.06%   90.07%           
=======================================
  Files         754      754           
  Lines      256360   256369    +9     
  Branches    48486    48494    +8     
=======================================
+ Hits       230891   230913   +22     
- Misses      16584    16597   +13     
+ Partials     8885     8859   -26

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva

panva commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-power9/64916/
https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix73-power9/64916/
https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-power9/64917/

appears to be a separate failure specific to AIX, i have no time to look into it now, @aduh95 @jasnell can you maybe take a look? or someone else

@aduh95 aduh95 mentioned this pull request Sep 1, 2026
Closed
aduh95 pushed a commit that referenced this pull request Sep 3, 2026
@panva @aduh95
test: fix recursive fs.watch error fixture
9966aa0 
Use a child directory so recursive watcher setup always creates a
second watch. Linux no longer watches regular files after the directory
watcher optimization.

Signed-off-by: Filip Skokan <[email protected]>
Assisted-by: Codex
PR-URL: #65683
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva @nodejs-github-bot @jasnell @RafaelGSS