CreateString() and Parse() in node_cjs_lexer.cc unconditionally called
ToLocalChecked() on the results of String::NewFromOneByte(),
String::NewFromUtf8() and Set::Add(). If string or handle allocation
fails or an exception is pending on the isolate, these return an empty
MaybeLocal and ToLocalChecked() aborts the process with
"FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal".

Since Parse() is on the hot path of every ESM import of a CJS module
(cjsPreparseModuleExports), propagate the failure as a regular pending
JavaScript exception instead so callers can recover.

Fixes: #63323
Refs: #61456
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: #63885
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Follow-up to aa25a0a. When an export or re-export name cannot be
converted to a V8 string (e.g. on string allocation failure), omit that
individual name and continue instead of bailing out of the whole
preparse. A single pathological name no longer fails the module's
exports preparse; the remaining names are still returned.

Refs: #63885
Refs: #63323
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: #63943
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>

Follow-up to aa25a0a. When an export or re-export name cannot be
converted to a V8 string (e.g. on string allocation failure), omit that
individual name and continue instead of bailing out of the whole
preparse. A single pathological name no longer fails the module's
exports preparse; the remaining names are still returned.

Refs: #63885
Refs: #63323
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: #63943
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>

CreateString() and Parse() in node_cjs_lexer.cc unconditionally called
ToLocalChecked() on the results of String::NewFromOneByte(),
String::NewFromUtf8() and Set::Add(). If string or handle allocation
fails or an exception is pending on the isolate, these return an empty
MaybeLocal and ToLocalChecked() aborts the process with
"FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal".

Since Parse() is on the hot path of every ESM import of a CJS module
(cjsPreparseModuleExports), propagate the failure as a regular pending
JavaScript exception instead so callers can recover.

Fixes: nodejs#63323
Refs: nodejs#61456
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#63885
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Follow-up to aa25a0a. When an export or re-export name cannot be
converted to a V8 string (e.g. on string allocation failure), omit that
individual name and continue instead of bailing out of the whole
preparse. A single pathological name no longer fails the module's
exports preparse; the remaining names are still returned.

Refs: nodejs#63885
Refs: nodejs#63323
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#63943
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>

CreateString() and Parse() in node_cjs_lexer.cc unconditionally called
ToLocalChecked() on the results of String::NewFromOneByte(),
String::NewFromUtf8() and Set::Add(). If string or handle allocation
fails or an exception is pending on the isolate, these return an empty
MaybeLocal and ToLocalChecked() aborts the process with
"FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal".

Since Parse() is on the hot path of every ESM import of a CJS module
(cjsPreparseModuleExports), propagate the failure as a regular pending
JavaScript exception instead so callers can recover.

Fixes: #63323
Refs: #61456
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: #63885
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Follow-up to aa25a0a. When an export or re-export name cannot be
converted to a V8 string (e.g. on string allocation failure), omit that
individual name and continue instead of bailing out of the whole
preparse. A single pathological name no longer fails the module's
exports preparse; the remaining names are still returned.

Refs: #63885
Refs: #63323
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: #63943
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>

Follow-up to aa25a0a. When an export or re-export name cannot be
converted to a V8 string (e.g. on string allocation failure), omit that
individual name and continue instead of bailing out of the whole
preparse. A single pathological name no longer fails the module's
exports preparse; the remaining names are still returned.

Refs: #63885
Refs: #63323
Signed-off-by: Yagiz Nizipli <[email protected]>
PR-URL: #63943
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>