build: build codecache and snapshot with libnode#63626
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
legendecas
force-pushed
the
static-intermediate
branch
2 times, most recently
from
May 28, 2026 20:16
adf769d to
fac4309
Compare
Signed-off-by: Chengzhong Wu <[email protected]>
legendecas
force-pushed
the
static-intermediate
branch
from
May 28, 2026 20:17
fac4309 to
e880392
Compare
joyeecheung
approved these changes
May 28, 2026
joyeecheung
left a comment
joyeecheung
left a comment
Member
There was a problem hiding this comment.
Thanks. LGTM if CI is happy!
github-actions
Bot
removed
the
request-ci
gurgunday
approved these changes
May 31, 2026
github-actions
Bot
removed
the
request-ci
joyeecheung
approved these changes
Jun 2, 2026
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3d35dd8 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
With the introduction of always static target `node_base`, `node_aix_shared` is now redundant. Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: #63747 Refs: #63626 Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: #63626 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
With the introduction of always static target `node_base`, `node_aix_shared` is now redundant. Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: #63747 Refs: #63626 Reviewed-By: Colin Ihrig <[email protected]>
luanmuniz
pushed a commit
to luanmuniz/node
that referenced
this pull request
Jun 25, 2026
With the introduction of always static target `node_base`, `node_aix_shared` is now redundant. Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: nodejs#63747 Refs: nodejs#63626 Reviewed-By: Colin Ihrig <[email protected]>
aduh95
added
the
backport-requested-v24.x
Contributor
|
This doesn't land cleanly on |
legendecas
added
the
backport-open-v24.x
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: #63626 Backport-PR-URL: #64632 Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
With the introduction of always static target `node_base`, `node_aix_shared` is now redundant. Signed-off-by: Chengzhong Wu <[email protected]> PR-URL: #63747 Backport-PR-URL: #64632 Refs: #63626 Reviewed-By: Antoine du Hamel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the
nodeandlibnodetargets, splitting thenode_mksnapshotaction from thenodeexe target, and adding a (always) staticnode_basetarget, allowinglibnodeto depend onnode_mksnapshotexe, enabling the node startup snapshot when building with flag--shared.The new dependency graph would be like: