quic: convert incoming :status header to number by hallss93 · Pull Request #63589 · nodejs/node

hallss93 · 2026-05-26T18:45:32Z

Summary

When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a
string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it
awkward to port HTTP/2 code to HTTP/3.

Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value
pairs. This applies to initial response headers, informational (1xx)
headers (oninfo), and stream.headers.

Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().

Test plan

Update existing QUIC H3 tests to expect numeric :status on receive
Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404

Run (with QUIC enabled):

node --experimental-quic --experimental-stream-iter --no-warnings \
  test/parallel/test-quic-h3-status-code-type.mjs \
  test/parallel/test-quic-h3-header-validation.mjs \
  test/parallel/test-quic-h3-informational-headers.mjs \
  test/parallel/test-quic-h3-request-response.mjs

nodejs-github-bot · 2026-05-26T18:45:37Z

Review requested:

@nodejs/quic

pimterry · 2026-05-28T09:35:52Z

@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.

codecov · 2026-05-28T10:15:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63589      +/-   ##
==========================================
- Coverage   90.32%   90.32%   -0.01%     
==========================================
  Files         759      759              
  Lines      248320   248330      +10     
  Branches    46868    46862       -6     
==========================================
- Hits       224296   224292       -4     
  Misses      15466    15466              
- Partials     8558     8572      +14

Files with missing lines	Coverage Δ
lib/internal/quic/quic.js	`100.00% <100.00%> (ø)`

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hallss93 · 2026-06-05T17:31:41Z

@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.

fixed

nodejs-github-bot · 2026-06-08T19:11:31Z

Commit Queue failed

- Loading data for nodejs/node/pull/63589
✔  Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title      quic: convert incoming :status header to number (#63589)
Author     Hallison Pereira Melo <[email protected]> (@hallss93, first-time contributor)
Branch     hallss93:quic-h3-status-number -> nodejs:main
Labels     needs-ci, quic, commit-queue-squash
Commits    2
 - quic: convert incoming :status header to number
 - Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
 - Hallison Melo <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 26 May 2026 18:45:32 GMT
   ✔  Approvals: 2
   ✔  - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
   ✔  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
 * branch                  refs/pull/63589/merge -> FETCH_HEAD
✔  Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
 Author: Hallison Melo <[email protected]>
 Date: Tue May 26 15:40:36 2026 -0300
 22 files changed, 117 insertions(+), 44 deletions(-)
 create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/27160616586

trivikr · 2026-06-09T03:46:07Z

@hallss93 Can you please rebase onto main and remove the merge commit?

Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase

bjohansebas

LGTM!

jasnell · 2026-08-08T18:08:15Z

Rebased to address the merge conflicts

jasnell · 2026-08-08T18:10:21Z

@Qard @pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase

Signed-off-by: Hallison Melo <[email protected]> Co-authored-by: Cursor <[email protected]>

nodejs-github-bot · 2026-08-08T18:29:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75664/

nodejs-github-bot · 2026-08-09T01:18:57Z

Landed in cbe18d8

Signed-off-by: Hallison Melo <[email protected]> Co-authored-by: Cursor <[email protected]> PR-URL: #63589 Fixes: #63557 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Tim Perry <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels May 26, 2026

hallss93 mentioned this pull request May 26, 2026

quic: http/3 headers behave differently than http/2 #63557

Closed

Qard approved these changes May 28, 2026

View reviewed changes

pimterry approved these changes May 28, 2026

View reviewed changes

hallss93 force-pushed the quic-h3-status-number branch from f442353 to 25644d0 Compare June 5, 2026 17:30

efekrskl approved these changes Jun 5, 2026

View reviewed changes

pimterry approved these changes Jun 8, 2026

View reviewed changes

pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 8, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 8, 2026

This comment was marked as outdated.

Sign in to view

pimterry added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jun 8, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 8, 2026

metcoder95 approved these changes Jun 21, 2026

View reviewed changes

bjohansebas approved these changes Jun 21, 2026

View reviewed changes

jasnell added this to QUIC Team Aug 8, 2026

jasnell moved this to In Progress in QUIC Team Aug 8, 2026

jasnell moved this from In Progress to Ready for Review in QUIC Team Aug 8, 2026

This comment was marked as resolved.

Sign in to view

jasnell force-pushed the quic-h3-status-number branch from 04c9e28 to 861d2a4 Compare August 8, 2026 18:07

This comment was marked as outdated.

Sign in to view

jasnell moved this from Ready for Review to Ready to Land in QUIC Team Aug 8, 2026

quic: convert incoming :status header to number

b9b662f

Signed-off-by: Hallison Melo <[email protected]> Co-authored-by: Cursor <[email protected]>

jasnell force-pushed the quic-h3-status-number branch from 861d2a4 to b9b662f Compare August 8, 2026 18:27

bjohansebas approved these changes Aug 8, 2026

View reviewed changes

Qard approved these changes Aug 8, 2026

View reviewed changes

bjohansebas added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 9, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 9, 2026

nodejs-github-bot merged commit cbe18d8 into nodejs:main Aug 9, 2026
68 checks passed

github-project-automation Bot moved this from Ready to Land to Done in QUIC Team Aug 9, 2026

github-actions Bot mentioned this pull request Aug 25, 2026

2026-08-26, Version 26.8.0 (Current) #65551

Merged

github-actions Bot mentioned this pull request Sep 7, 2026

2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873

Merged

This was referenced Oct 24, 2026

node:quic: derive header interest from onheaders, ontrailers and oninfo oven-sh/bun#46798

Closed

node:quic: keep a stream's headers and pendingTrailers after it closes oven-sh/bun#46841

Closed

Conversation

hallss93 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

nodejs-github-bot commented May 26, 2026

Uh oh!

pimterry commented May 28, 2026

Uh oh!

codecov Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hallss93 commented Jun 5, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jun 8, 2026

Uh oh!

trivikr commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjohansebas left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

jasnell commented Aug 8, 2026

Uh oh!

jasnell commented Aug 8, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Aug 8, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hallss93 commented May 26, 2026 •

edited

Loading

codecov Bot commented May 28, 2026 •

edited

Loading

trivikr commented Jun 9, 2026 •

edited

Loading