Repository navigation
Conversation
Signed-off-by: Alex Schwartz <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
alexsch01
marked this pull request as ready for review
May 13, 2026 17:30
Contributor
Author
|
Just saw the tests passed, can I have feedback on if this is a good idea or not? |
It fixes a major regression that makes Node binaries break on major Linux distributions by default so I’d say it’s a good idea. |
Contributor
Author
|
This or an alternative solution should be merged before v26 goes LTS |
|
CC @mcollina |
1 of 4 tasks
5 of 14 tasks
Oh well. |
|
@targos @legendecas @aduh95 @richardlau would one of you be able to take a look at these changes? this now affects v26 LTS users :( Thanks! |
legendecas
reviewed
Nov 9, 2026
| # Statically link libatomic for Linux Clang builds | ||
| ['OS=="linux" and clang==1', { | ||
| 'link_settings': { | ||
| 'libraries': ['<!@(clang++ -print-file-name=libatomic.a)', ], |
Member
There was a problem hiding this comment.
This should not hardcode clang++ in the gyp file. The library should be resolved in configure.gyp with CXX compiler like:
if is_clang and flavor == 'linux':
p = subprocess.check_output(shlex.split(CXX) + ['-print-file-name=libatomic.a']).decode().strip()
if os.path.isabs(p):
o['variables']['libatomic'] = p
else:
warn('libatomic.a not found; node will depend on libatomic.so.1 at runtime')
o['variables']['libatomic'] = '-latomic'And use it like:
'libraries': ['<(libatomic)'].
Member
|
Also, I think this would require |
This comment was marked as abuse.
This comment was marked as abuse.
|
When your app that was working no longer works, it’s your problem. It’s always your problem. Because it’s your app. And because you care that your app works. And launching is a big part of working. So regardless if upstream, downstream, sidestream, slipstream breaks it: you find a solution. Because all people see is your app crashing at startup when all the other apps they have don’t.
And maybe lay off the ad-hominems in a thread where people are trying to find a realistic universal solution that can be implemented within a practical timeframe instead of one that requires getting multiple operating systems to bend to your will.
…On Wed, Nov 11, 2026, at 11:27 AM, Öyvind Sæther wrote:
*oyvindsaether* left a comment (nodejs/node#63270) <#63270 (comment)>
A downstream Debian/Ubuntu package dependency issue should be taken up with Debian/Ubuntu the same way a broken nano package on MX Linux would be a MX Linux problem.
I find it amazing and hugely embarrassing that supposed IT "professionals" are clearly unable to understand this rather basic concept.
—
Reply to this email directly, view it on GitHub <#63270?email_source=notifications&email_token=AAAKGRUU42S7KOQAOR6VJXL5YRELBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZZGQ2TONZTGU3KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6794577356>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAKGRT2O4KIACNE4HK2TQD5YRELBAVCNFSNUABEKJSXA33TNF2G64TZHMZDOMJZGM3TOOJ3JFZXG5LFHM2DIMZSGY4DSNJUG2QXMAQ>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AAAKGRRTWD2PYD5J2J46HEL5YRELBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZZGQ2TONZTGU3KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/AAAKGRUIPHANQHRDAZSAV3T5YRELBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZZGQ2TONZTGU3KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because you commented.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60790