src: split profiling helpers from util#63008
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 1, 2026
Merged
Conversation
Signed-off-by: ishabi <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63008 +/- ##
========================================
Coverage 89.64% 89.64%
========================================
Files 707 710 +3
Lines 219509 220322 +813
Branches 42095 42255 +160
========================================
+ Hits 196775 197511 +736
- Misses 14628 14660 +32
- Partials 8106 8151 +45
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Apr 29, 2026
addaleax
added
the
author ready
github-actions
Bot
removed
the
request-ci
legendecas
reviewed
Apr 29, 2026
| @@ -0,0 +1,59 @@ | |||
| // Copyright Joyent, Inc. and other Node contributors. | |||
Member
There was a problem hiding this comment.
Is this file header necessary for these new files?
Member
Author
There was a problem hiding this comment.
Shouldn't we add the copyright for new created files?
Member
There was a problem hiding this comment.
@IlyasShabi we do not add license headers for new files. Also I think it is quite dismissive to land the PR while there is an open question
Member
Author
There was a problem hiding this comment.
I merged it after the CI finally passed and didn’t think your comment was blocking.
I see you opened a PR to remove it. Thanks
github-actions
Bot
removed
the
request-ci
IlyasShabi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 9ab960a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move CPU and heap profiling option parsing and heap profile serialization helpers to new file
src/node_profiling.cthis keep util smaller and have a profiling dedicated file.