Conversation
24b8585 made the CJS loader respect the `package.json` type field for extensionless files, which fixed #61104 but also enforced `"type": "module"` for extensionless files. This broke CJS extensionless files inside ESM packages (e.g. yargs v17). Only enforce `"type": "commonjs"` for extensionless files. For `"type": "module"`, leave format undefined so syntax detection handles it. This restores the documented exception in the CJS documentation that has existed since v16: extensionless files in `"type": "module"` packages are recognized as CJS when included via `require()`. Fixes: #61971 Refs: yargs/yargs#2509 Refs: #61600 PR-URL: #62083 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
It has better performance PR-URL: #61122 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Mark url.resolve() as deprecated Update also DEP0116 with cross-reference to DEP0169 PR-URL: #62002 Fixes: #61816 Refs: #61780 Reviewed-By: René <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>
PR-URL: #62026 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #61913 Fixes: #43433 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #61877 Reviewed-By: René <[email protected]>
PR-URL: #62048 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #62046 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #62049 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Release the async context frame in AsyncWrap::EmitDestroy to allow gc to collect it. This is in special relevant for reused resources like HTTPParser otherwise they might keep ALS stores alive. PR-URL: #61995 Fixes: #61882 Refs: #48528 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #61959 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #62033 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #61905 Reviewed-By: Antoine du Hamel <[email protected]>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.14.2 to 2.15.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@5ef0c07...a90bcbc) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #62064 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #61990 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.3 to 3.1.5. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.3...v3.1.5) --- updated-dependencies: - dependency-name: minimatch dependency-version: 3.1.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #62013 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #62100 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Signed-off-by: marcopiraccini <[email protected]> PR-URL: #62040 Fixes: #62036 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Mattias Buelens <[email protected]>
`changelog-maker` writes 10 character length short form SHA's. Explicitly set the `git log format` in the example to match. PR-URL: #62074 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #62076 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps the eslint group with 2 updates in the /tools/eslint directory: [eslint](https://github.com/eslint/eslint) and [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc). Updates `eslint` from 10.0.1 to 10.0.2 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.0.1...v10.0.2) Updates `eslint-plugin-jsdoc` from 62.7.0 to 62.7.1 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v62.7.0...v62.7.1) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: eslint-plugin-jsdoc dependency-version: 62.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #62092 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fix releaseWritingBuf() to correctly handle partial writes that split multi-byte UTF-8 characters. The previous implementation incorrectly converted byte counts to character counts, causing: - 3-byte characters (CJK) to be silently dropped - 4-byte characters (emoji) to leave lone surrogates in the buffer The fix backs up from the byte position to find a valid UTF-8 character boundary by checking for continuation bytes (pattern 10xxxxxx), then decodes the properly-aligned bytes to get the correct character count. Also fixes a typo where this._asyncDrainScheduled was used instead of the private field this.#asyncDrainScheduled. Fixes: #61744 PR-URL: #61745 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
When pipelined requests arrive in one TCP segment, llhttp_execute() parses them all in a single call. If a synchronous 'close' event handler invokes freeParser() mid-execution, cleanParser() nulls out parser state while llhttp_execute() is still on the stack, crashing on the next callback. Add an is_being_freed_ flag that freeParser() sets via parser.markFreed() before cleaning state. Proxy::Raw checks the flag before every callback and returns HPE_USER to abort execution early if set. PR-URL: #62095 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #62099 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #62099 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #60678 Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #62102 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #61876 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Aviv Keller <[email protected]>
This helps ensure that we already set the correct number of internal fields when creating objects, even if the number of internal fields of e.g. AsyncWrap changes over time. PR-URL: #62103 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
nodejs-github-bot
added a commit
that referenced
this pull request
Mar 10, 2026
Notable changes: PR-URL: #62184
This was invaluable for debugging the previous change, so I'm suggesting we add it regardless of it being a debugging-only API. PR-URL: #62103 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #62107 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: René <[email protected]>
Add incremental report writing after each spec completes and on worker errors so that reports survive if the process is killed before the exit handler runs. Add bytes() method to readAsFetch() to match the Response API used by newer WPT tests. PR-URL: #62107 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: René <[email protected]>
Pass rejectGarbageAfterEnd: true to createInflateRaw() and createBrotliDecompress(), matching the behavior already in place for deflate and gzip. The Compression Streams spec treats any data following a valid compressed payload as an error. When the underlying Node.js stream throws synchronously from write() (e.g. zlib rejects an invalid chunk type), destroy the stream so that the readable side is also errored. Without this, the readable side hangs forever waiting for data that will never arrive. Introduce a kValidateChunk callback option in the webstreams adapter layer. Compression streams use this to validate that chunks are BufferSource instances not backed by SharedArrayBuffer, replacing the previous monkey-patching of the underlying handle's write method. Unskip WPT compression bad-chunks tests which now run instead of hang and mark the remaining expected failures. PR-URL: #62107 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: René <[email protected]>
Convert brotli decompression errors to TypeError to match the Compression Streams spec, by extending handleKnownInternalErrors() in the adapters layer to recognize brotli error codes. This replaces the manual error event handler on DecompressionStream which was redundant with the adapter's built-in error propagation. PR-URL: #62107 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: René <[email protected]>
If the current SHA is not found in the README for some reason, exit with an error. PR-URL: #62121 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@b7c566a...bbbca2d) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #62062 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7.0.0 to 8.0.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@37930b1...70fc10c) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #62063 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #62134 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #62005 Fixes: #61724 Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #62079 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Original commit message:
PPC/S390: [wasm] Fix jump table offset when patching
... need to make sure patching of target occurs at the correct spot
based on what `EmitFarJumpSlot` emits. Also mask the branch offset in
PPC64 EmitJumpSlot to match `Assembler::b()`.
Change-Id: I5a8079d0079d8ad427034761d42c90b64d5746dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7642190
Reviewed-by: John <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#105646}
Refs: v8/v8@aa0b288
PR-URL: #62136
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
The timezone update script requires `icupkg` which doesn't appear to be available on `ubuntu-slim`. PR-URL: #62140 Fixes: #62109 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
* Make the intro less C++-centric * Give a GYP-less build example * Remove the duplicate Node-API documentation * Add an ESM example PR-URL: #62071 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Original commit message:
Fix resb on big endian platforms
Refs: unicode-org/icu4x@d310df8
Refs: unicode-org/icu4x#7658
PR-URL: #62138
Fixes: #61808
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #62147 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #62148 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #62149 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #62150 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #62151 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95
force-pushed
the
v25.8.1-proposal
branch
from
7802b9c to
2ea7a7b
Compare
Collaborator
aduh95
approved these changes
Mar 11, 2026
marco-ippolito
approved these changes
Mar 11, 2026
aduh95
pushed a commit
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
bab750d1b3] - build: do not depend on V8 deps on--without-bundled-v8builds (Antoine du Hamel) #62033b26d1c7fcb] - crypto: make --use-system-ca per-env rather than per-process (Aditi) #60678e362635abf] - crypto: add missing AES dictionaries (Filip Skokan) #620996f975db8af] - crypto: fix importKey required argument count check (Filip Skokan) #62099ab704d5875] - deps: update amaro to 1.1.8 (Node.js GitHub Bot) #62151fa627fb8c6] - deps: update sqlite to 3.52.0 (Node.js GitHub Bot) #62150d059bce0b8] - deps: update merve to 1.2.0 (Node.js GitHub Bot) #621491df038006c] - deps: patch resb crate (Richard Lau) #621387f5d68106c] - deps: V8: cherry-pick aa0b288f87cc (Richard Lau) #6213609191ad8b4] - deps: update ada to 3.4.3 (Node.js GitHub Bot) #6204924c1ca276d] - doc: copyeditaddons.md(Antoine du Hamel) #62071ad014eea81] - doc: correctutil.convertProcessSignalToExitCodevalidation behavior (René) #62134eeee7c7fb1] - doc: add efekrskl as triager (Efe) #61876db150b2e69] - doc: fix markdown forexpectFailurevalues (Jacob Smith) #62100d55a441e60] - doc: add title to index (Aviv Keller) #62046cc46204b48] - doc: include url.resolve() in DEP0169 application deprecation (Mike McCready) #620021d91a7261e] - doc,module: add missing doc for syncHooks.deregister() (Joyee Cheung) #619595198573bee] - http: fix use-after-free when freeParser is called during llhttp_execute (Gerhard Stöbich) #62095f8793f80df] - lib: fix source map url parse in dynamic imports (Chengzhong Wu) #619905cc0222b88] - meta: bump actions/download-artifact from 7.0.0 to 8.0.0 (dependabot[bot]) #620630a86186249] - meta: bump actions/upload-artifact from 6.0.0 to 7.0.0 (dependabot[bot]) #620625b266f3295] - meta: bump step-security/harden-runner from 2.14.2 to 2.15.0 (dependabot[bot]) #62064ea87eea71a] - module: fix extensionless CJS files in"type": "module"packages (Matteo Collina) #62083851228cd60] - sqlite: handle stmt invalidation (Guilherme Araújo) #618778f3b1269d7] - src: expose async context frame debugging helper to JS (Anna Henningsen) #621037dd5ca81a7] - src: convert context_frame field in AsyncWrap to internal field (Anna Henningsen) #621030257e8072f] - src: make AsyncWrap subclass internal field counts explicit (Anna Henningsen) #62103975dafbe3b] - src: release context frame in AsyncWrap::EmitDestroy (Gerhard Stöbich) #61995f2c08c7888] - src: use validate_ascii_with_errors instead of validate_ascii (Сковорода Никита Андреевич) #611220609510f48] - stream: optimize webstreams pipeTo (Mattias Buelens) #620799ec19e29f3] - stream: fix brotli error handling in web compression streams (Filip Skokan) #621074676f7d9ab] - stream: improve Web Compression spec compliance (Filip Skokan) #62107a5b1be2045] - stream: fix UTF-8 character corruption in fast-utf8-stream (Matteo Collina) #617455632446c4e] - stream: fix TransformStream race on cancel with pending write (Marco) #62040f90fa9cd1a] - stream: accept ArrayBuffer in CompressionStream and DecompressionStream (조수민) #61913701899e881] - test: update WPT for url to c928b19ab0 (Node.js GitHub Bot) #621484f7af00709] - test: update WPT for WebCryptoAPI to c9e955840a (Node.js GitHub Bot) #62147e3ebd6b019] - test: improve WPT report runner (Filip Skokan) #62107806e8b2032] - test: update WPT compression to ae05f5cb53 (Filip Skokan) #6210780f78f2737] - test: update WPT for WebCryptoAPI to 42e47329fd (Node.js GitHub Bot) #620488048e0508c] - test: fix skipping behavior fortest-runner-run-files-undefined(Antoine du Hamel) #6202625c34d74f4] - tools: revert timezone update GHA workflow to ubuntu-latest (Richard Lau) #62140da03301a10] - tools: improve error handling in test426 update script (Rich Trott) #62121710dde5ee2] - tools: fix--node-builtin-modules-pathvalue inshell.nix(Antoine du Hamel) #62102dcb1cbb21f] - tools: bump the eslint group across 1 directory with 2 updates (dependabot[bot]) #620927d0b758583] - tools: fix daily wpt workflow nighly release version lookup (Filip Skokan) #620763e8c816f2e] - tools: fix example in release proposal linter (Richard Lau) #62074772d3d270d] - tools: bump minimatch from 3.1.3 to 3.1.5 in /tools/clang-format (dependabot[bot]) #6201392f3b42672] - tools: bump eslint to v10, babel to v8.0.0-rc.2 (Huáng Jùnliàng) #61905c1dc86356b] - url: suppress warnings from url.format/url.resolve inside node_modules (René) #62005