test: limit the concurrency of WPTRunner for RISC-V #60591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For riscv64, the most commonly supported paging mode is sv39, which allocates 256GiB of virtual address space for the user space. However, due to trap handler security mechanism in V8, creating a wasm memory will cost 8GiB of continuous virtual address space. In a fresh node repl, I could only create 27 WebAssembly.Memory instances. When the virtual address space is more fragmented, it is worse. The wpt tests are randomly failing on riscv64 due to insufficient virtual address space to create wasm memories. This PR fixes it by limiting the concurrency of the WPTRunner to prevent the tests from creating too many wasm memories.
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60591 +/- ##
=======================================
Coverage 88.55% 88.56%
=======================================
Files 704 704
Lines 208077 208077
Branches 40076 40080 +4
=======================================
+ Hits 184271 184287 +16
+ Misses 15839 15824 -15
+ Partials 7967 7966 -1 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Nov 5, 2025
Contributor
Author
|
I think the macOS test failure here is unrelated: https://github.com/nodejs/node/actions/runs/19103557173/job/54581287952?pr=60591 |
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Nov 5, 2025
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Nov 7, 2025
- Fix test-strace-openat-openssl for RISC-V, upstreamed: nodejs/node#60588 - Fix randomly failing WPT tests, upstreamed: nodejs/node#60591 - Drop upstreamed patches - Temporarily disable test-snapshot-reproducible.js, I am still investigating it. - Now `check()` is supposed to pass, but some tests could hit revyos/revyos#27 on SG2042 so we might still need nocheck.
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Nov 7, 2025
- Fix test-strace-openat-openssl for RISC-V, upstreamed: nodejs/node#60588 - Fix randomly failing WPT tests, upstreamed: nodejs/node#60591 - Drop upstreamed patches - Temporarily disable test-snapshot-reproducible.js, I am still investigating it. - Now `check()` is supposed to pass, but some tests could hit revyos/revyos#27 on SG2042 so we might still need nocheck.
Contributor
Author
|
Hi, is there still anything I need to do to get this PR merged? Thanks. |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in cdc3ca8 |
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Nov 12, 2025
- Fix test-strace-openat-openssl for RISC-V, upstreamed: nodejs/node#60588 - Fix randomly failing WPT tests, upstreamed: nodejs/node#60591 - Drop upstreamed patches - Temporarily disable test-snapshot-reproducible.js, I am still investigating it. - Now `check()` is supposed to pass, but some tests could hit revyos/revyos#27 on SG2042 so we might still need nocheck.
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
For riscv64, the most commonly supported paging mode is sv39, which allocates 256GiB of virtual address space for the user space. However, due to trap handler security mechanism in V8, creating a wasm memory will cost 8GiB of continuous virtual address space. In a fresh node repl, I could only create 27 WebAssembly.Memory instances. When the virtual address space is more fragmented, it is worse. The wpt tests are randomly failing on riscv64 due to insufficient virtual address space to create wasm memories. This PR fixes it by limiting the concurrency of the WPTRunner to prevent the tests from creating too many wasm memories. PR-URL: #60591 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
9 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
For riscv64, the most commonly supported paging mode is sv39, which allocates 256GiB of virtual address space for the user space. However, due to trap handler security mechanism in V8, creating a wasm memory will cost 8GiB of continuous virtual address space. In a fresh node repl, I could only create 27 WebAssembly.Memory instances. When the virtual address space is more fragmented, it is worse. The wpt tests are randomly failing on riscv64 due to insufficient virtual address space to create wasm memories. This PR fixes it by limiting the concurrency of the WPTRunner to prevent the tests from creating too many wasm memories. PR-URL: #60591 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For riscv64, the most commonly supported paging mode is sv39, which allocates 256GiB of virtual address space for the user space. However, due to trap handler security mechanism in V8, creating a wasm memory will cost 8GiB of continuous virtual address space. In a fresh node repl, I could only create 27 WebAssembly.Memory instances. When the virtual address space is more fragmented, it is worse.
The wpt tests are randomly failing on riscv64 due to insufficient virtual address space to create wasm memories. This PR fixes it by limiting the concurrency of the WPTRunner on RISC-V to prevent the tests from creating too many wasm memories.