test: expand tls-check-server-identity coverage#60002
Closed
diangogav wants to merge 1 commit intonodejs:mainfrom
Closed
test: expand tls-check-server-identity coverage#60002diangogav wants to merge 1 commit intonodejs:mainfrom
diangogav wants to merge 1 commit intonodejs:mainfrom
Conversation
Contributor
diangogav
commented
Sep 24, 2025
diangogav
commented
- Falsy pattern via SAN: DNS: (triggers if (!pattern) return false)
- CN array with empty string: CN: ['']
- Empty label in pattern: bad..example.com (CN and SAN)
- Non-ASCII/blank label: caf\u00E9.example.com and bad label.com
- Multiple wildcards in first label: b**.a.com (CN and SAN)
- Prefix mismatch with single wildcard: ab*cd.a.com vs xbcd.a.com (CN and SAN)
nodejs-github-bot
added
needs-ci
|
Waiting for approval; |
RafaelGSS
reviewed
Sep 25, 2025
Member
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
Could you expand on why these additional checks are important? Any coverage info?
Contributor
Author
|
Hellooo @RafaelGSS ! I saw that some validations in the check function were not covered when looking at the coverage, and that is what this PR covers. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
RafaelGSS
approved these changes
Sep 25, 2025
Member
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
Never mind, the link you originally sent is enough. LGTM with green ci!
RafaelGSS
added
author ready
github-actions
bot
removed
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60002 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 703 703
Lines 207545 207529 -16
Branches 40013 40010 -3
=======================================
- Hits 183578 183572 -6
+ Misses 15957 15940 -17
- Partials 8010 8017 +7 🚀 New features to boost your workflow:
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
addaleax
approved these changes
Sep 30, 2025
addaleax
pushed a commit
that referenced
this pull request
Sep 30, 2025
PR-URL: #60002 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
|
Landed in 93ee08c |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #60002 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
PR-URL: #60002 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.