-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
deps: update V8 to 14.1 #59805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update V8 to 14.1 #59805
Conversation
|
Review requested:
|
|
/cc @lukealbao In case you have ideas on how to adapt |
|
@nodejs/platform-ppc @nodejs/platform-s390 we quickly get a compiler error: |
This might be a gcc issue. I'm working on a patch to make |
|
We no longer maintain gcc builds for RHEL on ppc64/s390x and builds now are using Clang. This patch which enables it on said platforms should already be part of 14.1: https://crrev.com/c/6705431 |
Above is with: FWIW https://ci.nodejs.org/job/node-test-commit-linuxone/51470/ (also with clang-19) passed. |
|
Is it possible that it's using the wrong version of the C++ standard library? Both errors are related to C++20 features. |
Quite possibly. Node.js built successfully with clang 19 for the equivalent platform: https://ci.nodejs.org/job/node-test-commit-linuxone/51470/ The IBM team that maintains the upstream Linux ppc64le and s390x ports build V8 with |
So I compared command lines for compiling On the LinuxONE machine: [iojs@test-ibm-rhel8-s390x-3 ~]$ clang++ -v -xc++ -
clang version 19.1.7 ( 19.1.7-2.module+el8.10.0+23045+e1f8e80e)
Target: s390x-redhat-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Configuration file: /etc/clang/s390x-redhat-linux-gnu-clang++.cfg
System configuration file directory: /etc/clang/
Selected GCC installation: /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14
Candidate multilib: .;@m64
Selected multilib: .;@m64
"/usr/bin/clang-19" -cc1 -triple s390x-redhat-linux-gnu -emit-obj -dumpdir a- -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model static -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu z10 -dwarf-version=4 -debugger-tuning=gdb -fdebug-compilation-dir=/home/iojs -v -fcoverage-compilation-dir=/home/iojs -resource-dir /usr/bin/../lib/clang/19 -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14 -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/s390x-redhat-linux -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/backward -internal-isystem /usr/bin/../lib/clang/19/include -internal-isystem /usr/local/include -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../s390x-redhat-linux/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdeprecated-macro -ferror-limit 19 -fno-signed-char -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/--98c169.o -x c++ -
clang -cc1 version 19.1.7 based upon LLVM 19.1.7 default target s390x-redhat-linux-gnu
ignoring nonexistent directory "/opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../s390x-redhat-linux/include"
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/s390x-redhat-linux
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/backward
/usr/bin/../lib/clang/19/include
/usr/local/include
/usr/include
End of search list.Note that the search paths point to the gcc-toolset-14 directories. Compare with passing [iojs@test-ibm-rhel8-s390x-3 ~]$ clang++ -v -xc++ --target=s390x-unknown-linux-gnu -
clang version 19.1.7 ( 19.1.7-2.module+el8.10.0+23045+e1f8e80e)
Target: s390x-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
System configuration file directory: /etc/clang/
Found candidate GCC installation: /usr/bin/../lib/gcc/s390x-redhat-linux/8
Selected GCC installation: /usr/bin/../lib/gcc/s390x-redhat-linux/8
Candidate multilib: .;@m64
Selected multilib: .;@m64
"/usr/bin/clang-19" -cc1 -triple s390x-unknown-linux-gnu -emit-obj -dumpdir a- -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model static -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu z10 -debugger-tuning=gdb -fdebug-compilation-dir=/home/iojs -v -fcoverage-compilation-dir=/home/iojs -resource-dir /usr/bin/../lib/clang/19 -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8 -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/s390x-redhat-linux -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/backward -internal-isystem /usr/bin/../lib/clang/19/include -internal-isystem /usr/local/include -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../s390x-redhat-linux/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdeprecated-macro -ferror-limit 19 -fno-signed-char -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/--5ab9ca.o -x c++ -
clang -cc1 version 19.1.7 based upon LLVM 19.1.7 default target s390x-redhat-linux-gnu
ignoring nonexistent directory "/usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../s390x-redhat-linux/include"
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
/usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8
/usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/s390x-redhat-linux
/usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/backward
/usr/bin/../lib/clang/19/include
/usr/local/include
/usr/include
End of search list.I think the target is used to search for a config, e.g. in the default case it finds a configuration file [iojs@test-ibm-rhel8-s390x-3 ~]$ ls -al /etc/clang
total 16
drwxr-xr-x 2 root root 4096 Aug 14 21:00 .
drwxr-xr-x. 95 root root 4096 Aug 14 21:00 ..
-rw-r--r-- 1 root root 128 Apr 22 18:08 s390x-redhat-linux-gnu-clang++.cfg
-rw-r--r-- 1 root root 128 Apr 22 18:08 s390x-redhat-linux-gnu-clang.cfg
[iojs@test-ibm-rhel8-s390x-3 ~]$and FWIW [iojs@test-ibm-rhel8-s390x-3 ~]$ cat /etc/clang/s390x-redhat-linux-gnu-clang++.cfg
--gcc-triple=s390x-redhat-linux -gdwarf-4 -g0 --gcc-install-dir=/opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14
[iojs@test-ibm-rhel8-s390x-3 ~]$I could try creating a |
|
@nodejs/platform-windows There are two issues on Windows: test-worker-profcppgc addon |
|
wrt. the V8 CI on Linux ppc64le and s390x. I have opened #59893 and nodejs/build#4153 which combined with this PR has enabled the V8 CI to build with clang. I also updated the Jenkins job to erase the This test CI is a combination of the above changes and this PR: https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/746/ |
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs/node#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This should replace #58491
Still blocked at least on nodejs/build#4083V8 CI is also broken because--always-turbofanflag was removed. I tried to fix it in canary with ab7d369, but thentest/v8-updates/test-linux-perf-logger.jsfails because the functions don't get optimized: https://ci.nodejs.org/job/node-test-commit-v8-linux/6742/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/consoleNotable changes since 13.7:
JSON.stringifyperformance improvements