Skip to content

lib: map Latin1 labels to iso-8859-1 instead of Windows-1252 #58890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lytovka wants to merge 7 commits into from
Closed

lib: map Latin1 labels to iso-8859-1 instead of Windows-1252 #58890

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50aa8bc
lib: map Latin1 labels to iso-8859-1 encoding
lytovka Jun 29, 2025
1bf1c92
test: fix label assertions in existing tests
lytovka Jun 29, 2025
8819222
test: decode 0x7F-0x9F bytes with windows-1252 encoding
lytovka Jun 29, 2025
2813ea4
test: revert removal of windows-1254 labels
lytovka Jun 29, 2025
eff9039
test: remove unnecessary console.log
lytovka Jun 29, 2025
7143420
test: remove unnecessary comments
lytovka Jun 29, 2025
43fbb04
test: fix linting errors
lytovka Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix linting errors
  • Loading branch information
@lytovka
lytovka committed Jun 30, 2025
commit 43fbb04b9ba14f6f251d6a9d00ce5bd0bfcd75c7
7 changes: 2 additions & 5 deletions test/parallel/test-whatwg-encoding-custom-textdecoder-windows1252-decoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,14 @@ const assert = require('assert');
[0x9C, 0x0153], // LATIN SMALL LIGATURE OE
[0x9D, 0x009D], // UNDEFINED
[0x9E, 0x017E], // LATIN SMALL LETTER Z WITH CARON
[0x9F, 0x0178] // LATIN CAPITAL LETTER Y WITH DIAERESIS
[0x9F, 0x0178], // LATIN CAPITAL LETTER Y WITH DIAERESIS
];

for (let i = 0; i < win1252_0x7F_0x9F.length; i++) {
const byte = win1252_0x7F_0x9F[i][0];
const expectedUnicodeCode = win1252_0x7F_0x9F[i][1];
const arr = new Uint8Array([byte]);
let decoded;
assert.doesNotThrow(() => {
decoded = new TextDecoder("windows-1252").decode(arr);
}, `Decoding byte ${byte} should not throw`);
const decoded = new TextDecoder('windows-1252').decode(arr);
assert.strictEqual(decoded.length, 1, `Decoded string for ${byte} should have length 1`);
const actualUnicodeCode = decoded.codePointAt(0);
assert.strictEqual(actualUnicodeCode, expectedUnicodeCode, `Decoded code point for ${byte} should be U+${expectedUnicodeCode.toString(16).toUpperCase()}`);
Expand Down
Loading