tty: treat empty NO_COLOR same as absent NO_COLOR
#58074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Apr 29, 2025
targos
approved these changes
Apr 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58074 +/- ##
==========================================
- Coverage 90.09% 90.07% -0.02%
==========================================
Files 640 640
Lines 188450 188450
Branches 36966 36962 -4
==========================================
- Hits 169789 169752 -37
- Misses 11364 11396 +32
- Partials 7297 7302 +5
🚀 New features to boost your workflow:
|
BridgeAR
reviewed
Apr 29, 2025
BridgeAR
added
the
semver-major
Contributor
Author
|
@BridgeAR is it semver-major or just a fix? Wdyt about not landing it on LTS release lines to minimize the risk of ecosystem breakage, but still land it on Current release line? |
Member
|
@aduh95 I think it's fine to land it on 24 or do you mean any release before? |
aduh95
added
dont-land-on-v18.x
dont-land-on-v20.x
BridgeAR
approved these changes
May 3, 2025
BridgeAR
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/58074 ✔ Done loading data for nodejs/node/pull/58074 ----------------------------------- PR info ------------------------------------ Title tty: treat empty `NO_COLOR` same as absent `NO_COLOR` (#58074) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-no-color -> nodejs:main Labels tty, author ready, needs-ci, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x Commits 4 - tty: treat empty `NO_COLOR` same as absent `NO_COLOR` - fixup! tty: treat empty `NO_COLOR` same as absent `NO_COLOR` - Revert "fixup! tty: treat empty `NO_COLOR` same as absent `NO_COLOR`" - fixup! tty: treat empty `NO_COLOR` same as absent `NO_COLOR` Committers 1 - Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58074 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58074 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 29 Apr 2025 10:23:00 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58074#pullrequestreview-2803306357 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/58074#pullrequestreview-2803318306 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/58074#pullrequestreview-2813243352 ✘ Last GitHub CI failed ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14811753178 |
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
May 7, 2025
Member
|
@aduh95 this has some conflicts. It could otherwise likely land. |
Contributor
Author
|
Landed in afbf2f3 |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58074 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in https://no-color.org/, setting the env variable to an empty string should result in that env variable to be ignored: