Skip to content

child_process: clone spawn options argument#579

Closed
cjihrig wants to merge 1 commit intonodejs:v1.xfrom
cjihrig:576
Closed

child_process: clone spawn options argument#579
cjihrig wants to merge 1 commit intonodejs:v1.xfrom
cjihrig:576

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Jan 23, 2015

spawnSync() modifies the options argument. This commit makes a copy of options before any modifications occur. Fixes #576

@cjihrig
child_process: clone spawn options argument
ce4b2cc 
spawnSync() modifies the options argument. This commit makes
a copy of options before any modifications occur.
@hail2u hail2u mentioned this pull request Jan 23, 2015
Closed
@piscisaureus
Copy link
Copy Markdown
Contributor

piscisaureus commented Jan 23, 2015

LGTM if it passes CI. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/104/

@piscisaureus
Copy link
Copy Markdown
Contributor

piscisaureus commented Jan 23, 2015

Unfortunately the CI seems to be broken atm. Summoning @rvagg - I tried to build the branch "try" but it doesn't work.

@bnoordhuis
Copy link
Copy Markdown
Member

bnoordhuis commented Jan 23, 2015

@piscisaureus I think your forgot to set user to 'cjihrig' (edit: and branch to '576'.)

@piscisaureus
Copy link
Copy Markdown
Contributor

piscisaureus commented Jan 23, 2015

@bnoordhuis Nope, tried it again, doesn't work. Can you try?

@bnoordhuis
Copy link
Copy Markdown
Member

bnoordhuis commented Jan 23, 2015

@piscisaureus https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/105/ looks like it's building the right commit.

@piscisaureus
Copy link
Copy Markdown
Contributor

piscisaureus commented Jan 24, 2015

looks like it's building the right commit.

You said nothing too much.

@piscisaureus
Copy link
Copy Markdown
Contributor

piscisaureus commented Jan 24, 2015

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/113/

@cjihrig
Copy link
Copy Markdown
Contributor Author

cjihrig commented Jan 24, 2015

@piscisaureus - The Ubuntu failure is test-vm-timeout. The OS X failure is test-fs-watch - this didn't fail for me locally on OS X, and I believe TJ was seeing timeouts on this test today with joyent/node.

@piscisaureus
Copy link
Copy Markdown
Contributor

piscisaureus commented Jan 26, 2015

@cjihrig please land

cjihrig added a commit that referenced this pull request Jan 26, 2015
@cjihrig
child_process: clone spawn options argument
7854811 
spawnSync() modifies the options argument. This commit makes
a copy of options before any modifications occur.

Fixes: #576
PR-URL: #579
Reviewed-By: Bert Belder <[email protected]>
@cjihrig
Copy link
Copy Markdown
Contributor Author

cjihrig commented Jan 26, 2015

Landed in 7854811

@cjihrig cjihrig closed this Jan 26, 2015
@cjihrig cjihrig deleted the 576 branch January 26, 2015 17:05
@jonathanong
Copy link
Copy Markdown
Contributor

jonathanong commented Jan 26, 2015

can we make it not touch the options object instead of copying it?

@cjihrig
Copy link
Copy Markdown
Contributor Author

cjihrig commented Jan 26, 2015

You're welcome to try.

@hail2u hail2u mentioned this pull request Feb 7, 2015
Closed
@aliscco aliscco mentioned this pull request Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig @piscisaureus @bnoordhuis @jonathanong