Skip to content

doc: explicitly state that corepack will be removed in v25+#57747

Merged
nodejs-github-bot merged 2 commits intomainfrom
corepack-removal-version
Apr 7, 2025
Merged

doc: explicitly state that corepack will be removed in v25+#57747
nodejs-github-bot merged 2 commits intomainfrom
corepack-removal-version

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Apr 4, 2025

The generic "future versions of" Node.js is causing a confusion among corepack users.
Example nodejs/corepack#688 (comment)

This PR explicitly changes it to v25+ as agreed in TSC vote in nodejs/TSC#1697 (comment)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2025
@trivikr trivikr mentioned this pull request Apr 4, 2025
Closed
@trivikr trivikr changed the title docs: explicitly state that corepack will be removed in v25+ doc: explicitly state that corepack will be removed in v25+ Apr 4, 2025
@MikeMcC399
Copy link
Copy Markdown
Contributor

MikeMcC399 commented Apr 4, 2025

@trivikr

Thank you for picking this up! As you know, I unsuccessfully raised it in #57708 (comment). Admittedly there were multiple issues I raised in that one issue.

It looks like you'll need to update your commit though, to change docs: to doc:

image

@trivikr trivikr force-pushed the corepack-removal-version branch from 683c103 to 1a83409 Compare April 4, 2025 16:32
@trivikr
Copy link
Copy Markdown
Member Author

trivikr commented Apr 4, 2025

It looks like you'll need to update your commit though, to change docs: to doc:

Thanks! I force-pushed in 1a83409

MikeMcC399
MikeMcC399 reviewed Apr 4, 2025
View reviewed changes
Comment thread doc/api/corepack.md Outdated
@trivikr trivikr requested review from MikeMcC399 and aduh95 and removed request for MikeMcC399 April 4, 2025 16:46
styfle
styfle approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarity!

MikeMcC399
MikeMcC399 reviewed Apr 5, 2025
View reviewed changes
Comment thread doc/api/corepack.md
Despite Corepack being distributed with default installs of Node.js, the package
managers managed by Corepack are not part of the Node.js distribution, and
Corepack itself will no longer be distributed with future versions of Node.js.
Corepack itself will no longer be distributed with Node.js 25+.
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 Apr 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trivikr

I'll just remove the v as of now, and will wait for input from other collaborators

Using the notation from https://github.com/nodejs/release including the use of the term "release line" to refer to all releases with same major version number:

Suggested change
Corepack itself will no longer be distributed with Node.js 25+.
Corepack itself will no longer be distributed with release lines Node.js 25 and above.

You could also write "releases Node.js >=25.0.0" using semver notation.

@MikeMcC399 MikeMcC399 mentioned this pull request Apr 6, 2025
Closed
@trivikr trivikr self-assigned this Apr 7, 2025
@trivikr trivikr added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit b6a10f7 into main Apr 7, 2025
22 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 7, 2025

Landed in b6a10f7

@nodejs-github-bot nodejs-github-bot deleted the corepack-removal-version branch April 7, 2025 15:53
@trivikr trivikr mentioned this pull request Apr 10, 2025
Merged
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@trivikr @JonasBa
doc: explicitly state that corepack will be removed in v25+
615b69b 
PR-URL: nodejs#57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@trivikr @RafaelGSS
doc: explicitly state that corepack will be removed in v25+
e5223d9 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@trivikr @RafaelGSS
doc: explicitly state that corepack will be removed in v25+
952a212 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
5b79f16 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@trivikr @RafaelGSS
doc: explicitly state that corepack will be removed in v25+
bfaacea 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
46d463b 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
dd98c28 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
6718abb 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
561a65f 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
92428c2 
PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@gurgunday gurgunday gurgunday approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

+3 more reviewers

@MikeMcC399 MikeMcC399 MikeMcC399 left review comments

@styfle styfle styfle approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@trivikr trivikr

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.