crypto: fix output of privateDecrypt with zero-length data #57575
+57
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
confirmed-bug
|
Review requested:
|
nodejs-github-bot
added
dependencies
jasnell
approved these changes
Mar 21, 2025
This was referenced Mar 21, 2025
Closed
lpinca
approved these changes
Mar 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57575 +/- ##
==========================================
- Coverage 90.24% 90.22% -0.03%
==========================================
Files 630 630
Lines 185013 185054 +41
Branches 36249 36251 +2
==========================================
- Hits 166969 166961 -8
- Misses 10996 11030 +34
- Partials 7048 7063 +15 🚀 New features to boost your workflow:
|
panva
added
author ready
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Mar 21, 2025
anonrig
added
the
commit-queue
tniessen
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
LGTM.
Optional nit: I'd prefer the test to have a less generic name, and ideally a reference to the GitHub issue describing the bug, but this is optional. For example, you could rename to test-crypto-oaep-zero-length and add a comment with a reference to the issue or rename to test-crypto-oaep-issue-57553 or so.
|
@tniessen thank you, I will take care of it if CI happens to fail again, otherwise in a followup PR. |
panva
added
request-ci
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57575 ✔ Done loading data for nodejs/node/pull/57575 ----------------------------------- PR info ------------------------------------ Title crypto: fix output of privateDecrypt with zero-length data (#57575) Author Filip Skokan <[email protected]> (@panva) Branch panva:fix-57553 -> nodejs:main Labels confirmed-bug, crypto, author ready, needs-ci, dependencies, webcrypto, commit-queue-squash Commits 3 - crypto: fix output of privateDecrypt with zero-length data - fixup! crypto: fix output of privateDecrypt with zero-length data - fixup! crypto: fix output of privateDecrypt with zero-length data Committers 1 - Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57575 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57575 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - crypto: fix output of privateDecrypt with zero-length data ⚠ - fixup! crypto: fix output of privateDecrypt with zero-length data ⚠ - fixup! crypto: fix output of privateDecrypt with zero-length data ℹ This PR was created on Fri, 21 Mar 2025 13:37:08 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57575#pullrequestreview-2705979199 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57575#pullrequestreview-2706110397 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57575#pullrequestreview-2706396429 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/57575#pullrequestreview-2706526720 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-03-31T18:32:13Z: https://ci.nodejs.org/job/node-test-pull-request/65913/ - Querying data for job/node-test-pull-request/65913/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14180649182 |
panva
removed
the
commit-queue-failed
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 12b81df |
aduh95
pushed a commit
that referenced
this pull request
Apr 1, 2025
closes #57553 closes #57572 closes #57558 PR-URL: #57575 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #57553
closes #57572
closes #57558
refs #56653