doc: update maintaining-openssl.md for openssl #57413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
Update the instructions for maintaining OpenSSL in the Node.js source tree to reflect switching back from the quictls fork of OpenSSL back to official OpenSSL.
lpinca
approved these changes
Mar 11, 2025
RafaelGSS
approved these changes
Mar 11, 2025
marco-ippolito
approved these changes
Mar 11, 2025
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 81d3db2 |
aduh95
pushed a commit
that referenced
this pull request
Mar 18, 2025
Update the instructions for maintaining OpenSSL in the Node.js source tree to reflect switching back from the quictls fork of OpenSSL back to official OpenSSL. PR-URL: #57413 Refs: #57301 Refs: #57142 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
Update the instructions for maintaining OpenSSL in the Node.js source tree to reflect switching back from the quictls fork of OpenSSL back to official OpenSSL. PR-URL: #57413 Refs: #57301 Refs: #57142 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
Update the instructions for maintaining OpenSSL in the Node.js source tree to reflect switching back from the quictls fork of OpenSSL back to official OpenSSL. PR-URL: #57413 Refs: #57301 Refs: #57142 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the instructions for maintaining OpenSSL in the Node.js source tree to reflect switching back from the quictls fork of OpenSSL back to official OpenSSL.
Refs: #57335 (comment)
Refs: #57301
Refs: #57142
AFAICT we've been cherry-picking the OpenSSL commits from
maintov23.x-staging,v22.x-staging,v20.x-stagingandv18.x-staginginstead of opening release line specific pull requests. This is much easier with the update tooling, but does mean the step for updating the 32-bit Windows assembler directives needs to happen (the automation does this) even though we don't build/test on 32-bit Windows from Node.js 23 onwards.