doc: add thekemkid to collaborators#5667
Merged
GlenTiki merged 1 commit intonodejs:masterfrom Mar 12, 2016
Merged
Conversation
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
LGTM! |
GlenTiki
force-pushed
the
add-collaborator-thekemkid
branch
from
d12f3a3 to
36178bc
Compare
Contributor
|
The second line of the commit message should be blank. Other than that, LGTM. |
GlenTiki
force-pushed
the
add-collaborator-thekemkid
branch
from
36178bc to
2d01078
Compare
GlenTiki
force-pushed
the
add-collaborator-thekemkid
branch
from
2d01078 to
dccdd3c
Compare
PR-URL: nodejs#5667 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
GlenTiki
force-pushed
the
add-collaborator-thekemkid
branch
from
dccdd3c to
4daab7f
Compare
Member
|
@thekemkid hey, in the future please see https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests - we don't merge using the GitHub merge button. I'm not sure if that's what you did here - but just for future reference. |
Contributor
Author
|
I didn't use the button, as there's no commit (EDIT: merge) message O.o I rebased my branch onto a local master and pushed that to upstream. I expected to have to close this after pushing, but github closed for me. |
Member
|
Welcome @thekemkid! Good to have you on board! |
evanlucas
pushed a commit
that referenced
this pull request
Mar 14, 2016
PR-URL: #5667 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
PR-URL: #5667 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
|
🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
PR-URL: #5667 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
PR-URL: #5667 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
PR-URL: #5667 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
Description of change
Adding myself to the collaborator list