Skip to content

fs: refactoring declaratively with the Array.fromAsync function #54644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 12 commits into from
Sep 27, 2024
Merged

fs: refactoring declaratively with the Array.fromAsync function #54644

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
07d075a
fs: refactoring declaratively with the fromAsync function
sonsurim Aug 29, 2024
e2d8a69
fs: replace global Array to primordials ArrayFromAsync
sonsurim Aug 29, 2024
dde434c
fix lint error
sonsurim Aug 29, 2024
f4025e5
benchmark: add fs glob benchmark
sonsurim Sep 9, 2024
1a9ae15
lint js
sonsurim Sep 9, 2024
db16e20
refactor glob benchmark
sonsurim Sep 12, 2024
43ef1e4
reflected review in glob benchmark
sonsurim Sep 12, 2024
cb2591a
remove an unused variable
sonsurim Sep 12, 2024
1ff400e
applied review on glob benchmark
sonsurim Sep 12, 2024
c976446
fix error where benchmarking type does not match in CI
sonsurim Sep 13, 2024
7dbb93f
remove parts that affect benchmarking
sonsurim Sep 14, 2024
defe492
fix too many cases for benchmarking
sonsurim Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix too many cases for benchmarking
  • Loading branch information
@sonsurim
sonsurim committed Sep 24, 2024
commit defe49213673606aa85c2129bf85b2e9dce5637b
2 changes: 1 addition & 1 deletion benchmark/fs/bench-glob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const benchmarkDirectory = path.resolve(__dirname, '..', '..');

const configs = {
n: [1e3],
dir: ['lib', 'test/parallel', 'benchmark'],
dir: ['lib'],
pattern: ['**/*', '*.js', '**/**.js'],
mode: ['async', 'sync'],
Comment thread
aduh95 marked this conversation as resolved.
recursive: ['true', 'false'],
Copy link
Copy Markdown
Member

@avivkeller avivkeller Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
recursive: ['true', 'false'],
recursive: [true, false],

Copy link
Copy Markdown
Contributor Author

@sonsurim sonsurim Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't seem to use boolean in benchmark (error on CI), so I fixed that in this commit!

Many Thanks!

Expand Down