Skip to content

doc, sqlite: add --experimental-sqlite note#53907

Merged
nodejs-github-bot merged 4 commits intonodejs:mainfrom
avivkeller:patch-81
Jul 19, 2024
Merged

doc, sqlite: add --experimental-sqlite note#53907
nodejs-github-bot merged 4 commits intonodejs:mainfrom
avivkeller:patch-81

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Jul 17, 2024

Fixes #53906

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem. labels Jul 17, 2024
avivkeller
avivkeller commented Jul 17, 2024
View reviewed changes
Comment thread doc/api/sqlite.md Outdated
@avivkeller
Copy link
Copy Markdown
Member Author

avivkeller commented Jul 18, 2024

Note that the subsystem is doc, not sqlite, as nodejs/core-validate-commit#121 has not landed yet.

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Jul 18, 2024

Note that the subsystem is doc, not sqlite, as nodejs/core-validate-commit#121 has not landed yet.

Even if nodejs/core-validate-commit#121 had landed, we'd want doc: for the subsystem here

aduh95
aduh95 reviewed Jul 18, 2024
View reviewed changes
Comment thread doc/api/sqlite.md Outdated
@avivkeller avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 18, 2024
@avivkeller avivkeller requested a review from aduh95 July 18, 2024 19:25
aduh95
aduh95 reviewed Jul 18, 2024
View reviewed changes
Comment thread doc/api/sqlite.md Outdated
@avivkeller @aduh95
Update doc/api/sqlite.md
4301043 
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6fc0218 into nodejs:main Jul 19, 2024
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 19, 2024

Landed in 6fc0218

targos pushed a commit that referenced this pull request Jul 28, 2024
@avivkeller @targos
doc: add --experimental-sqlite note
8bf9960 
PR-URL: #53907
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
@lheckemann
Copy link
Copy Markdown

lheckemann commented Dec 26, 2024

This doesn't seem to be showing on https://nodejs.org/docs/latest-v23.x/api/sqlite.html -- is something wrong, or am I misunderstanding where it should be?

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Dec 26, 2024

@lheckemann SQLite integration was unflagged in #55890, which has landed on latest v23.x. The note is showing on older v23.x releases, e.g. https://nodejs.org/docs/v23.0.0/api/sqlite.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H4ad H4ad H4ad approved these changes

@aduh95 aduh95 aduh95 approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document that using node:sqlite requires --experimental-sqlite flag

7 participants

@avivkeller @aduh95 @nodejs-github-bot @lheckemann @H4ad @atlowChemi @targos