Skip to content

src: fix typo Unabled -> Unable#52820

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
SimonSiefke:patch-1
May 11, 2024
Merged

src: fix typo Unabled -> Unable#52820
nodejs-github-bot merged 1 commit intonodejs:mainfrom
SimonSiefke:patch-1

Conversation

@SimonSiefke
Copy link
Contributor

@SimonSiefke SimonSiefke commented May 3, 2024

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 3, 2024
@avivkeller
Copy link
Member

avivkeller commented May 3, 2024

Thanks for the PR! Please update the commit message to behind with the subsystem being changed, in this case, src:

src: fix typo Unabled -> Unable

@avivkeller avivkeller added fast-track PRs that do not need to wait for 72 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Fast-track has been requested by @redyetidev. Please 👍 to approve.

@avivkeller
Copy link
Member

avivkeller commented May 3, 2024

Fast-Tracking, as this a pretty simple change.

@avivkeller avivkeller removed the needs-ci PRs that need a full CI run. label May 4, 2024
@avivkeller
Copy link
Member

avivkeller commented May 4, 2024

Removing needs-ci, as this is a simple text-based error change, and it's change won't affect any testing / building

@aduh95 aduh95 added needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 72 hours to land. labels May 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 5, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58948/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 5, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58953/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59086/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 04fbd0d into nodejs:main May 11, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 11, 2024

Landed in 04fbd0d

targos pushed a commit that referenced this pull request May 11, 2024
@SimonSiefke @targos
src: fix typo Unabled -> Unable
75004d3 
PR-URL: #52820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 13, 2024
Merged
@SimonSiefke SimonSiefke deleted the patch-1 branch May 14, 2024 15:28
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@SimonSiefke @marco-ippolito
src: fix typo Unabled -> Unable
7f6d7cd 
PR-URL: #52820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@SimonSiefke @marco-ippolito
src: fix typo Unabled -> Unable
8a6ee85 
PR-URL: #52820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@SimonSiefke @marco-ippolito
src: fix typo Unabled -> Unable
b162aea 
PR-URL: #52820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
eliiphaz pushed a commit to eliiphaz/node that referenced this pull request Jun 20, 2024
@SimonSiefke @eliiphaz
src: fix typo Unabled -> Unable
90a755c 
PR-URL: nodejs#52820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@SimonSiefke @bmeck
src: fix typo Unabled -> Unable
69c24d1 
PR-URL: nodejs#52820
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@SimonSiefke @avivkeller @nodejs-github-bot @jasnell @lpinca @tniessen @richardlau @marco-ippolito @HarshithaKP @aduh95