Skip to content

Updating to DCO 1.1#5170

Closed
mikeal wants to merge 2 commits intonodejs:masterfrom
mikeal:dco-1.1
Closed

Updating to DCO 1.1#5170
mikeal wants to merge 2 commits intonodejs:masterfrom
mikeal:dco-1.1

Conversation

@mikeal
Copy link
Copy Markdown
Contributor

@mikeal mikeal commented Feb 9, 2016

We should be using the latest version of the DCO approved by lawyers who know more about all of this than we do :)

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Feb 9, 2016
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Feb 9, 2016

LGTM

rvagg
rvagg reviewed Feb 9, 2016
View reviewed changes
Comment thread CONTRIBUTING.md Outdated


## Developer's Certificate of Origin 1.0
# Developer's Certificate of Origin 1.1
Copy link
Copy Markdown
Member

@rvagg rvagg Feb 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs another #

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Feb 9, 2016

lgtm sans style nit

@mikeal
Copy link
Copy Markdown
Contributor Author

mikeal commented Feb 9, 2016

Fixed the style nit.

@thefourtheye
Copy link
Copy Markdown
Contributor

thefourtheye commented Feb 9, 2016

Should we link the source? I could find the text here http://developercertificate.org. Change LGTM.

@mikeal
Copy link
Copy Markdown
Contributor Author

mikeal commented Feb 9, 2016

We can't modify the text in any way so if we did a link it would have to a linkified header. Stylistically we don't do that anywhere else.

@thefourtheye
Copy link
Copy Markdown
Contributor

thefourtheye commented Feb 9, 2016

Then its okay. I was just wondering if it is okay to copy the text without the source.

@mikeal
Copy link
Copy Markdown
Contributor Author

mikeal commented Feb 9, 2016

From the site:

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

@bnoordhuis
Copy link
Copy Markdown
Member

bnoordhuis commented Feb 10, 2016

LGTM except for the commit log.

@MylesBorins
Copy link
Copy Markdown
Contributor

MylesBorins commented Feb 11, 2016

LGTM as long as commits are updated

rvagg pushed a commit that referenced this pull request Feb 12, 2016
@mikeal @rvagg
doc: update DCO to v1.1
d78e679 
PR-URL: #5170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@rvagg
Copy link
Copy Markdown
Member

rvagg commented Feb 12, 2016

squashed and commit msg updated, landed @ d78e679

rvagg pushed a commit that referenced this pull request Feb 15, 2016
@mikeal @rvagg
doc: update DCO to v1.1
18b00de 
PR-URL: #5170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Fishrock123
Copy link
Copy Markdown
Contributor

Fishrock123 commented Feb 17, 2016

Looks like this landed? Closing..

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Feb 18, 2016

whoops, thanks @Fishrock123

MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@mikeal
doc: update DCO to v1.1
7cdfc6e 
PR-URL: #5170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@mikeal
doc: update DCO to v1.1
c3c5498 
PR-URL: #5170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
stefanmb pushed a commit to stefanmb/node that referenced this pull request Feb 23, 2016
@mikeal @stefanmb
doc: update DCO to v1.1
d1c7a15 
PR-URL: nodejs#5170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@mikeal
doc: update DCO to v1.1
c4d1e3d 
PR-URL: #5170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@williamkapke williamkapke mentioned this pull request Apr 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mikeal @jasnell @rvagg @thefourtheye @bnoordhuis @MylesBorins @Fishrock123 @mscdex