Skip to content

tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]#50459

Merged
aduh95 merged 1 commit intomainfrom
actions/tools-update-doc
Dec 11, 2023
Merged

Conversation

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot commented Oct 29, 2023 •
edited by aduh95
Loading

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 29, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

nodejs-github-bot commented Oct 29, 2023

Review requested:

  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 29, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

nodejs-github-bot commented Oct 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55304/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

nodejs-github-bot commented Oct 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55306/

MoLow
MoLow previously approved these changes Oct 29, 2023
View reviewed changes
@lpinca lpinca added the blocked PRs that are blocked by other issues or PRs. label Oct 29, 2023
@lpinca
Copy link
Copy Markdown
Member

lpinca commented Oct 29, 2023

See #50414.

@github-actions github-actions Bot mentioned this pull request Oct 30, 2023
Open
25 tasks
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Oct 30, 2023

I think the logical fix is to build the docs with a stable node binary on the without-intl job, so we don't crash the build if the deps uses a regex with the u flag. @nodejs/build how can we make this happen? IIRC the setup job is not available publicly, only a build member can do this sort of change.

@richardlau
Copy link
Copy Markdown
Member

richardlau commented Oct 30, 2023

@aduh95 FWIW the without-intl job runs:

NODE_TEST_DIR=/home/iojs/node-tmp FLAKY_TESTS=dontcare CONFIG_FLAGS=' --without-intl' make run-ci -j 4

Given that we describe how to build without intl in https://github.com/nodejs/node/blob/main/BUILDING.md#building-without-intl-support I'd prefer if we had a solution that worked without involving changes to the Jenkins job -- i.e. running the Makefile after configure --without-intl should just work.

@github-actions github-actions Bot mentioned this pull request Oct 31, 2023
Open
17 tasks
@aduh95 aduh95 force-pushed the actions/tools-update-doc branch from 002a698 to 88b53dd Compare December 10, 2023 23:38
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Dec 10, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

nodejs-github-bot commented Dec 10, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56213/

@aduh95 aduh95 merged commit ab93a35 into main Dec 11, 2023
@aduh95 aduh95 deleted the actions/tools-update-doc branch December 11, 2023 00:41
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Dec 11, 2023

Landed in ab93a35

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@nodejs-github-bot @RafaelGSS
tools: update doc to [email protected] [email protected]
297cb6f 
And [email protected].

PR-URL: #50459
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@nodejs-github-bot @richardlau
tools: update doc to [email protected] [email protected]
c7350c2 
And [email protected].

PR-URL: #50459
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

@MoLow MoLow MoLow left review comments

+1 more reviewer

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nodejs-github-bot @lpinca @aduh95 @richardlau @jasnell @MoLow @aymen94