Skip to content

doc: add loong64 info into platform list#50086

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
shipujin:loong64-dev
Oct 22, 2023
Merged

doc: add loong64 info into platform list#50086
nodejs-github-bot merged 1 commit intonodejs:mainfrom
shipujin:loong64-dev

Conversation

@shipujin
Copy link
Copy Markdown
Member

@shipujin shipujin commented Oct 8, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 8, 2023
@shipujin
Copy link
Copy Markdown
Member Author

shipujin commented Oct 8, 2023

unofficial-builds:

@shipujin shipujin mentioned this pull request Oct 9, 2023
Closed
mhdawson
mhdawson approved these changes Oct 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos
targos requested changes Oct 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@targos targos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to us have a @nodejs/platform-loong64 team with people that we can ping when there are loong64 issues before landing this. I just created a label

@targos targos added the loong64 Issues and PRs related to the loong64 architecture. label Oct 19, 2023
@shipujin
Copy link
Copy Markdown
Member Author

shipujin commented Oct 19, 2023

I'd like to us have a @nodejs/loong64 team with people that we can ping when there are loong64 issues before landing this. I just created a label

That's great! I would like to participate and join '@nodejs/loong64', when there is a loong64 problem, you can quickly ping me.

Best regards~

@targos targos mentioned this pull request Oct 19, 2023
Closed
targos
targos approved these changes Oct 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team was created.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7dc74a0 into nodejs:main Oct 22, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 22, 2023

Landed in 7dc74a0

targos pushed a commit that referenced this pull request Oct 23, 2023
@shipujin @targos
doc: add loong64 info into platform list
c40de82 
PR-URL: #50086
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@shipujin @alexfernandez
doc: add loong64 info into platform list
ccbc240 
PR-URL: nodejs#50086
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@shipujin @targos
doc: add loong64 info into platform list
ea28738 
PR-URL: #50086
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
@shipujin shipujin deleted the loong64-dev branch August 11, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

+2 more reviewers

@mhdawson mhdawson mhdawson approved these changes

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. loong64 Issues and PRs related to the loong64 architecture.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shipujin @nodejs-github-bot @bnoordhuis @anonrig @targos @richardlau @mhdawson @aymen94