Skip to content

assert: deprecate callTracker #47740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Apr 29, 2023
Merged

assert: deprecate callTracker #47740

nodejs-github-bot merged 1 commit into from
Apr 29, 2023

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Apr 27, 2023

Closes: #47492

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Apr 27, 2023
@MoLow MoLow force-pushed the deprecate-calltracker branch from 6529cf0 to 7d43bc6 Compare April 27, 2023 06:54
tniessen
tniessen reviewed Apr 27, 2023
View reviewed changes
@MoLow
Copy link
Member Author

MoLow commented Apr 27, 2023

CC @nodejs/assert

deokjinkim
deokjinkim reviewed Apr 27, 2023
View reviewed changes
@ErickWendel
Copy link
Member

ErickWendel commented Apr 27, 2023

LGTM

@MoLow MoLow force-pushed the deprecate-calltracker branch from 7e7dfc2 to a1634a7 Compare April 27, 2023 19:26
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51516/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51518/

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2023
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Open
29 tasks
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51525/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51528/

@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Open
32 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit adf332b into nodejs:main Apr 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 29, 2023

Landed in adf332b

This was referenced Apr 30, 2023
Open
Open
@Renegade334 Renegade334 mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen left review comments

@deokjinkim deokjinkim deokjinkim left review comments

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@ErickWendel ErickWendel ErickWendel approved these changes

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discussion: assert.CallTracker future

9 participants

@MoLow @ErickWendel @nodejs-github-bot @aduh95 @jasnell @benjamingr @tniessen @deokjinkim @danielleadams