src: fix negative nodeTiming milestone values #46588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Member
Author
|
#43781 didn't land on v14.x and v16.x, so this fix doesn't need to land on v14.x and v16.x too. |
addaleax
reviewed
Feb 9, 2023
legendecas
force-pushed
the
perf_hooks/time_origin
branch
from
b318df3 to
6760c9a
Compare
jasnell
approved these changes
Feb 20, 2023
github-actions
bot
removed
the
request-ci
26 tasks
This was referenced Feb 25, 2023
github-actions
bot
removed
the
request-ci
16 tasks
Member
Author
|
Fixed the test failure with |
This was referenced Mar 1, 2023
jasnell
approved these changes
Mar 2, 2023
JungMinu
approved these changes
Mar 2, 2023
legendecas
added a commit
that referenced
this pull request
Mar 2, 2023
PR-URL: #46588 Fixes: #45958 Refs: #43781 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Member
Author
|
Landed in a8c3d03 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46588 Fixes: #45958 Refs: #43781 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46588 Fixes: #45958 Refs: #43781 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Contributor
|
@legendecas this didn't land cleanly on v18.x - do you mind opening a backport PR? Thank you |
Member
Author
|
#43781 didn't land on v18.x. I'm tagging this as https://github.com/nodejs/node/labels/dont-land-on-v18.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the
performance.timeOriginis a Web API, Node.js specific extensionperformance.nodeTimingexposes the process performance milestones in the main thread and the worker threads. In order to avoid exposing negative values inperformance.nodeTiming, set theperformance.timeOriginto the start time of the process both in the main thread and worker threads.Refs: #43781
Fixes #45958, with regression test cases.