[v18.x] deps: patch V8 to 10.2.154.26#46446
Closed
targos wants to merge 1 commit intonodejs:v18.x-stagingfrom
Closed
[v18.x] deps: patch V8 to 10.2.154.26#46446targos wants to merge 1 commit intonodejs:v18.x-stagingfrom
targos wants to merge 1 commit intonodejs:v18.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Jan 31, 2023
gengjiawen
approved these changes
Jan 31, 2023
github-actions
Bot
removed
the
request-ci
Member
Author
|
Landed in 0f29b57 |
targos
added a commit
that referenced
this pull request
Feb 5, 2023
Refs: v8/v8@10.2.154.23...10.2.154.26 PR-URL: #46446 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
sepehrst
pushed a commit
to sepehrst/node
that referenced
this pull request
Feb 14, 2023
Refs: v8/v8@10.2.154.23...10.2.154.26 PR-URL: nodejs#46446 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
|
FYI: the change in |
Member
Author
|
I wonder if this affects ChromeOS 102. It is still in LTS until Mar 9 2023 so I would expect Google to backport the fix in V8. |
Contributor
|
@targos what was fixed in this patch, and how important is it for existing 18.4.1 prod deployments? |
|
For reference, here's a simple reproducer based on the testcase in the above-mentioned V8 commit: $ curl -LO https://gist.github.com/kleisauke/0084ac571832295019bf5feca99ada02/raw/a42c0cd38f8d402d2a87b9d8017c075be8542767/spiller.wasm
$ node -v
v18.14.1
$ node --noliftoff -e "WebAssembly.instantiate(fs.readFileSync('./spiller.wasm')).then(obj => console.log(obj.instance.exports.main().toString(16)))"
12345678000000
$ node -v
v18.14.2
$ node --noliftoff -e "WebAssembly.instantiate(fs.readFileSync('./spiller.wasm')).then(obj => console.log(obj.instance.exports.main().toString(16)))"
5678000000(see https://gist.github.com/kleisauke/0084ac571832295019bf5feca99ada02 for the And here's a more complicated reproducer: Details$ mkdir wasm-vips-test && cd wasm-vips-test
$ npm init -y
$ npm install wasm-vips
$ curl -LO https://github.com/kleisauke/wasm-vips/raw/master/test/unit/images/sample.png
$ cat <<EOT > test.mjs
import Vips from 'wasm-vips';
const vips = await Vips();
const im = vips.Image.newFromFile('sample.png', {
fail_on: 'warning'
});
console.log(im.avg());
im.delete();
vips.shutdown();
EOT$ node -v
v18.14.1
$ node test.mjs
30498.1968091746
$ node -v
v18.14.2
$ node test.mjs
(process:42): VIPS-WARNING **: 17:36:33.618: pngload: invalid scanline filter
(process:42): VIPS-WARNING **: 17:36:33.625: error in tile 0 x 48
...
Error: unable to call avg
pngload: libspng read error |
This was referenced Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@10.2.154.23...10.2.154.26