Skip to content

deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64#46401

Closed
shipujin wants to merge 1 commit intonodejs:mainfrom
shipujin:main
Closed

deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64#46401
shipujin wants to merge 1 commit intonodejs:mainfrom
shipujin:main

Conversation

@shipujin
Copy link
Copy Markdown
Member

@shipujin shipujin commented Jan 29, 2023

Add linux64-loongarch64 into Makefile
And run make

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Jan 29, 2023
@shipujin
Copy link
Copy Markdown
Member Author

shipujin commented Jan 29, 2023

Hello, I add LoongArch target to openssl/openssl [3.0]:openssl/openssl#18807
Add loongarch64 target: quictls/openssl: quictls/openssl@c09ce49

nodejs/deps/openssl: https://github.com/nodejs/node/blob/main/deps/openssl/openssl/Configurations/10-main.conf#L821
thanks~

bnoordhuis
bnoordhuis approved these changes Jan 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Not a blocker for this PR but I notice files in e.g. deps/openssl/config/archs/*/no-asm/providers are all exactly the same.

We should try to deduplicate those because they add up to substantial source code bloat, roughly 1.9 MB * number of targets. It's 38 MB now and this PR brings it to 40 MB.

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49230/

@bnoordhuis bnoordhuis mentioned this pull request Feb 1, 2023
Open
@shipujin
Copy link
Copy Markdown
Member Author

shipujin commented May 4, 2023

Update

mhdawson
mhdawson approved these changes May 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 4, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51635/

This was referenced May 5, 2023
Open
Open
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 6, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51686/

This was referenced May 7, 2023
Open
Open
Open
Open
mhdawson pushed a commit that referenced this pull request May 16, 2023
@shipujin @mhdawson
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
a51491a 
PR-URL: #46401
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented May 16, 2023

Landed in a51491a

@mhdawson mhdawson closed this May 16, 2023
@shipujin shipujin mentioned this pull request May 23, 2023
Closed
targos pushed a commit that referenced this pull request May 30, 2023
@shipujin @targos
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
c6a7525 
PR-URL: #46401
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
Merged
@shipujin
Copy link
Copy Markdown
Member Author

shipujin commented Jul 14, 2023

[v18.x backport] deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 #48135

ruyadorno pushed a commit that referenced this pull request Aug 16, 2023
@ruyadorno
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
f4617a4 
Add linux64-loongarch64 into Makefile
And run make

PR-URL: #46401
Backport-PR-URL: #48135
Reviewed-By: Ben Noordhuis [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michael Dawson [email protected]
@ruyadorno ruyadorno mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shipujin @nodejs-github-bot @mhdawson @bnoordhuis @jasnell @ruyadorno @danielleadams