Skip to content

crypto: fix CipherBase Update int32 overflow #45769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Dec 9, 2022
+13 −1
Merged

crypto: fix CipherBase Update int32 overflow #45769

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f439605
crypto: fix CipherBase Update int32 overflow
marco-ippolito Dec 7, 2022
e9c81a8
Update test/parallel/test-crypto-cipheriv-decipheriv.js
panva Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/parallel/test-crypto-cipheriv-decipheriv.js
  • Loading branch information
@panva
panva authored Dec 7, 2022
commit e9c81a8c824a70a8d03c0f2a914e23ce393ed6b6
10 changes: 5 additions & 5 deletions test/parallel/test-crypto-cipheriv-decipheriv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ for (let n = minIvLength; n < maxIvLength; n += 1) {
}

{
// overflowing
assert.throws(() => crypto.createCipheriv('aes-128-gcm', Buffer.alloc(16), Buffer.alloc(12))
.update(Buffer.allocUnsafeSlow(2 ** 31 - 1)), {
name: 'Error',
});
// https://github.com/nodejs/node/issues/45757
// eslint-disable-next-line no-restricted-syntax
assert.throws(() =>
crypto.createCipheriv('aes-128-gcm', Buffer.alloc(16), Buffer.alloc(12))
.update(Buffer.allocUnsafeSlow(2 ** 31 - 1)));
Comment thread
panva marked this conversation as resolved.
}