[v18.x backport] lib: refactor transferable AbortSignal#44941
[v18.x backport] lib: refactor transferable AbortSignal#44941flakey5 wants to merge 1 commit intonodejs:v18.x-stagingfrom
Conversation
Co-authored-by: James M Snell <[email protected]> PR-URL: nodejs#44048 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot
added
needs-ci
aduh95
changed the title
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM but obviously we need a releaser to take a look. @nodejs/releasers
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi @flakey5 - it looks like this test is breaking on one of the machines. Since it's a OOM error, I think the tuning on the test needs to be adjusted, and since it's an abort test, I think it's related. I'm going to move forward with the next v18 release, but once this is fixed it should be good to go for the next v18 release (but it will probably need a rebase). |
This seems to be flakey in the staging branch too, so I'm going to go ahead and land this. |
Co-authored-by: James M Snell <[email protected]> PR-URL: #44048 Backport-PR-URL: #44941 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
Landed in 3f20e5b |
6 participants
Backport of #44048 to v18.x
cc @mcollina