test: don't use cwd for relative path#4477
Merged
jbergstroem merged 1 commit intonodejs:masterfrom Dec 30, 2015
Merged
Conversation
Member
Author
|
Will likely get a fail on raspberry pi because the path to common pipe will be too long. A fix for that would either be making it flaky for a while ("fix") or changing the temporary path which we explore through #4476. |
Member
Author
|
@Trott mentions that this actually doesn't properly address relative tests. Will address shortly. |
Member
|
LGTM if CI is happy (or happier) |
Member
Author
Member
|
Bonus benefit is that you can run this with CWD of |
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: nodejs#4477 Reviewed-By: Rich Trott <[email protected]>
jbergstroem
force-pushed
the
fix/realpath-relative-baseurl
branch
from
ccc802d to
6efa031
Compare
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: nodejs#4477 Reviewed-By: Rich Trott <[email protected]>
Member
|
@thealphanerd This will need land on v4.x-staging since #3325 has landed and made the temp dir customizable via NODE_TEST_DIR while removing NODE_COMMON_PIPE. |
jasnell
pushed a commit
that referenced
this pull request
Jan 15, 2016
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: #4477 Reviewed-By: Rich Trott <[email protected]>
Member
|
Landed in v4.x-staging in bb2e2d0 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: #4477 Reviewed-By: Rich Trott <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code. PR-URL: nodejs#4477 Reviewed-By: Rich Trott <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of temporary paths in the test runner realpath tests would bail in scenarios where the temporary folder wasn't in the same directory as the source code.
/R=@Trott?