Skip to content

events: expose CustomEvent on the global scope via a CLI flag#43885

Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom
daeyeon:main.customevent-220718.Mon.ddf1
Jul 23, 2022
Merged

events: expose CustomEvent on the global scope via a CLI flag#43885
nodejs-github-bot merged 3 commits intonodejs:mainfrom
daeyeon:main.customevent-220718.Mon.ddf1

Conversation

@daeyeon
Copy link
Copy Markdown
Member

@daeyeon daeyeon commented Jul 18, 2022

Fixes: #40678
Refs: #43514

Signed-off-by: Daeyeon Jeong [email protected]

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@Mesteery Mesteery Mesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. eventtarget Issues and PRs related to the EventTarget implementation. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support CustomEvent

7 participants

@daeyeon @nodejs-github-bot @targos @aduh95 @lpinca @RaisinTen @Mesteery