Skip to content

tools: fix find-inactive actions #43377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 3 commits into from
Jun 11, 2022
Merged

tools: fix find-inactive actions #43377

nodejs-github-bot merged 3 commits into from
Jun 11, 2022

Conversation

@LiviaMedeiros
Copy link
Member

@LiviaMedeiros LiviaMedeiros commented Jun 11, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2022

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 11, 2022
@LiviaMedeiros LiviaMedeiros added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2022

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

@aduh95
Copy link
Contributor

aduh95 commented Jun 11, 2022

We also probably want to revert using a hash instead of v1 as it looks like that doesn't work for some reason: https://github.com/nodejs/node/runs/6842110279?check_suite_focus=true

@LiviaMedeiros
Copy link
Member Author

LiviaMedeiros commented Jun 11, 2022 •
edited
Loading

Thanks for checking that! I think we should use gr2m/create-or-update-pull-request-action@6720400 instead.
https://github.com/gr2m/create-or-update-pull-request-action/blob/6720400cad8e74d7adc64640e4e6ea6748b83d8f/dist/index.js
There's no /dist/ in their master branch.

@aduh95
Copy link
Contributor

aduh95 commented Jun 11, 2022

I just tried this PR over at https://github.com/nodejs/node-auto-test/runs/6842347772?check_suite_focus=true, and it opened nodejs/node-auto-test#48 just fine 👍

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit e227e52 into nodejs:master Jun 11, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2022

Landed in e227e52

This was referenced Jun 11, 2022
Merged
Merged
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@LiviaMedeiros @danielleadams
tools: fix find-inactive actions
495aaa9 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@LiviaMedeiros @danielleadams
tools: fix find-inactive actions
f25cd11 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@LiviaMedeiros @danielleadams
tools: fix find-inactive actions
8c0fe1e 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@LiviaMedeiros @targos
tools: fix find-inactive actions
ec419e5 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@LiviaMedeiros @targos
tools: fix find-inactive actions
ddea965 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@LiviaMedeiros @guangwong
tools: fix find-inactive actions
4bc23ea 
PR-URL: nodejs/node#43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiviaMedeiros @nodejs-github-bot @aduh95 @Trott