Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Closed
juanarbol
force-pushed
the
v17.9.0-proposal
branch
from
43f5727 to
a8c0383
Compare
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
force-pushed
the
v17.9.0-proposal
branch
from
a8c0383 to
b23be87
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Commit message should be changed from |
targos
reviewed
Apr 5, 2022
targos
previously requested changes
Apr 5, 2022
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
there seems to be a semver-major change
aduh95
reviewed
Apr 5, 2022
VoltrexKeyva
added
release
BethGriggs
requested changes
Apr 5, 2022
Member
BethGriggs
left a comment
BethGriggs
left a comment
There was a problem hiding this comment.
In addition to the other’s comments, we'll need to update the target release date in the changelog and the commit message
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
force-pushed
the
v17.9.0-proposal
branch
from
5ea0dad to
70dcef5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/43373/ |
aduh95
approved these changes
Apr 7, 2022
BethGriggs
approved these changes
Apr 7, 2022
richardlau
approved these changes
Apr 7, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
One more resume CI...we've been unlucky hitting machine disconnects: |
Collaborator
Member
juanarbol
added a commit
that referenced
this pull request
Apr 7, 2022
juanarbol
added a commit
to juanarbol/nodejs.org
that referenced
this pull request
Apr 7, 2022
BethGriggs
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Apr 7, 2022
This was referenced Apr 8, 2022
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Notable Changes: * (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) nodejs#42427 * deps: update undici to 4.16.0 (Node.js GitHub Bot) nodejs#42414 * doc: add @meixg to collaborators (Xuguang Mei) nodejs#42576 PR-URL: nodejs#42613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022-04-07, Version 17.9.0 (Current), @BethGriggs prepared by @juanarbol
Notable Changes
7124f91cbf] - (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) #4242730dc6dd3fb] - deps: update undici to 4.16.0 (Node.js GitHub Bot) #42414f0fc2744a5] - doc: add @meixg to collaborators (Xuguang Mei) #42576Commits
bb71433334] - async_hooks: remove destroyed symbol on Promises (Gerhard Stöbich) #42402b48a6cb3f9] - bootstrap: reset process._exit and process.exitCode in pre-execution (Joyee Cheung) #42466b89f038537] - bootstrap: run inspector and event loop in snapshot builder (Joyee Cheung) #42466177558600e] - bootstrap: make I/O streams work with user-land snapshot (Joyee Cheung) #42466e3683cb34d] - bootstrap: refresh options in pre-execution (Joyee Cheung) #42466d302d2f0d2] - bootstrap: use SnapshotData to pass snapshot data around (Joyee Cheung) #42360eb3dfc00f0] - buffer: improve Blob constructor error message when passing a string (Xuguang Mei) #42338f45d5537c1] - buffer: fixatobinput validation (Antoine du Hamel) #42539fb6a5ba8d7] - build: remove precompiled header and debug information for host builds (Niyas Sait) #425381f7d2e800c] - build: windows/arm64 native compilation support (Niyas Sait) #42408d9a1d7866c] - build: consolidate JS and md linting GitHub Actions (Rich Trott) #42572ecb5be845d] - build: set stale action back to running nightly (Michael Dawson) #42549f9fb7f6d96] - build: add --node-snapshot-main configure option (Joyee Cheung) #42466c6808f088b] - build: bump actions/checkout (Eliaz Bobadilla) #424609a54acb7c6] - child_process: add env contents types in JSDoc (Rich Trott) #42494a2f07380ea] - crypto: do not add undefined hash in webcrypto normalizeAlgorithm (Filip Skokan) #425599b4bd7d031] - crypto: cleanup webcrypto jwk code (Filip Skokan) #42562541a1328b0] - crypto: fix webcrypto derive key lengths (Filip Skokan) #425427124f91cbf] - (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) #4242730dc6dd3fb] - deps: update undici to 4.16.0 (Node.js GitHub Bot) #424146e56924274] - doc: simplify Http2Stream encoding text (Rich Trott) #42597261672b1da] - doc: remove obsolete stream API selection text (Rich Trott) #42586beffed1880] - doc: remove faulty justification for 128-bit AES (Tobias Nießen) #4257871f4a39086] - doc: fix documentation ofFileHandle.prototype.appendFile(Antoine du Hamel) #42588c83ea22f7c] - doc: change "OCSP Request" to "OCSP request" (Tobias Nießen) #4258271ab0dea35] - doc: aes webcrypto unwrap is not a node-specific extensions (Filip Skokan) #425611c614184da] - doc: simplify recommendations in process.md (Rich Trott) #42556c036800ddc] - doc: clarify recommendations in stream.md (Rich Trott) #42555dcf0abf8c7] - doc: simplify recommendation in webcrypto.md (Rich Trott) #425548333fa063b] - doc: update DEP0102 text (Rich Trott) #425538b08bff682] - doc: remove util.promisify() content in readline.md (Rich Trott) #4255294492424ba] - doc: add introduction sentence for CJS (Antoine du Hamel) #42491f0fc2744a5] - doc: add @meixg to collaborators (Xuguang Mei) #42576d935fef594] - doc: consolidate CI sections (Rich Trott) #42534fd45df314b] - doc: document breaking change inhttp.IncomingMessage'close'event (Paolo Insogna) #4252153584fa750] - doc: remove extraneous comma (Rich Trott) #42548b819af6509] - doc: guide towards x509.fingerprint256 (Tobias Nießen) #42516f2355e41ed] - doc: fix internal link in collaborator-guide.md (Daeyeon Jeong) #42551ffc6776996] - doc: add suggestion for OpenSSL only sec releases (Michael Dawson) #424561454c0297d] - doc: fix comment text in async_hooks example (Rich Trott) #42499b9ab9867f4] - doc: addstabilityclass to legacy status description (Daniel Roe) #425256c13988d53] - doc: suggest checkHost in checkServerIdentity docs (Tobias Nießen) #4249528665a9dd6] - doc: update security release onboarding (Joe Sepi) #42333d335addf0c] - doc: fix question promise API example (Xuguang Mei) #424657cf9febcb4] - doc: remove comma splice in events.md (Rich Trott) #424843c3684d9f1] - doc: clarify napi_finalize behavior (Alba Mendez) #42461334cc1936b] - doc: expand history for conditional exports changes in v12 (Greg Poole) #42339fb146f9eaf] - doc: change comma-splice to two sentences (Rich Trott) #42455ce4b823946] - doc: add link to section (Rich Trott) #424285869275479] - doc: fix typo in async_context.md (Anupama Codippily) #4244448bd9fa2c7] - doc: addtrace_gcto diagnostic tooling support document (Tony Gorez) #4234600f693b6b1] - doc: make header smaller and dropdown click-driven when JS is on (Paolo Insogna) #42165abbb23620a] - doc: standardize typography for _semantic versioning_ (Rich Trott) #42401e763e575c6] - doc: unify import order in CCM example (Tobias Nießen) #4239410d638a735] - doc: update property name (Rich Trott) #423985589a448b7] - doc,test: clarify ChaCha20-Poly1305 usage (Tobias Nießen) #42323902776e674] - esm: emit experimental warnings in common place (Jacob Smith) #423148009cb0a78] - fs: fix write methods param validation and docs (Livia Medeiros) #42631a9dc3a92d9] - lib: prepare files for no-var lint rule (Rich Trott) #425733306fee824] - lib: source maps filter null prefix (Fabian Cook) #425223bac969655] - lib: improve the coverage of the validator (mawaregetsuka) #42443b74de21cc3] - lib: update JSDoc for linting (Rich Trott) #424897766bf954f] - meta: update .mailmap and AUTHORS (Rich Trott) #4260293ffc5535a] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42500256509056d] - meta: update AUTHORS (Node.js GitHub Bot) #4258541c2a32390] - meta: update AUTHORS (Node.js GitHub Bot) #42488b71a8107c0] - net,dns: trace tcp connection and dns by perf_hooks (theanarkh) #42390f9f3b6e45d] - node-api: format Node-API related code (Vladimir Morozov) #423960bd9d9e24f] - os: avoid unnecessary usage of var (Mohammed Keyvanzadeh) #42563e798e26dfd] - src: add proper mutexes for accessing FIPS state (Anna Henningsen) #42278a1fe0d2222] - src: fix typo in InspectorIoDelegate constructor (Kohei Ueno) #425200c54f3637b] - src: remove unnecessary static qualifier in crypto_dh.cc (Darshan Sen) #424922e6a66d7d7] - src: address 3 useless call coverity warnings (Michael Dawson) #42426ce9d840079] - src: properly report exceptions from AddressToJS() (Darshan Sen) #42054c6a558c61b] - src: suppress false coverity warning (Michael Dawson) #42284878148c266] - src: refactor IsSupportedAuthenticatedMode (Tobias Nießen) #42368970483ffd3] - src,crypto: handle empty maybe correctly in crypto_dh.cc (Darshan Sen) #42492a348f8ac1a] - src,crypto: remove uses of AllocatedBuffer from crypto_dh.cc (Darshan Sen) #42492fb25ba435c] - test: improve lib/internal/readline/promises.js coverage (MURAKAMI Masahiko) #424204cbb1ea910] - test: remove hack foratobandbtoaWPT tests (Antoine du Hamel) #42540f41a4780d5] - test: pass data into napi_create_external (Joyee Cheung) #4253290554572b5] - test: improveFileHandle.prototype.writecoverage (Antoine du Hamel) #42541797994e4c0] - test: add test for exception handlings in debugger (Kohei Ueno) #423278c9b5e9a36] - test: fix typo in common/wpt.js (Ikko Ashimine) #425672f682091cd] - test: fix typos in test/parallel (Daeyeon Jeong) #4250252d1c8d6d9] - test: add trace-gc flag test (Tony Gorez) #4247119c933c79a] - test,fs: add fs.rm() tests for .git directories (Darshan Sen) #42410d64c4fb94d] - tools: enable no-var ESLint rule for lib (Rich Trott) #42573a9f2636d12] - tools: fixed bug causing JSON format to be broken (mawaregetsuka) #41565bff9cae16a] - tools: update GHA actions version (Antoine du Hamel) #42498c6bfb225cd] - tools: update eslint to 8.12.0 (Node.js GitHub Bot) #42489464e57ffc7] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #4248713dd8e73df] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #424163a1b0e5b87] - tools: bump cpplint to 1.6.0 (Rich Trott) #424169344a06d9c] - tools: fix skip PR if CI is still running (Xuguang Mei) #42377