v17.7.1 release proposal#42285
Merged
Merged
Conversation
This reverts commit 010cb71. Refs: #42279 PR-URL: #42280 Fixes: #42279 Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs-github-bot
added
meta
sxa
added a commit
that referenced
this pull request
Mar 10, 2022
Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 when the url has @ characters in it, which showed up when using yarn v1. This version reverts the change that introduced the regression PR-URL: #42285
Member
Author
|
@Trott If you get the chance LMK if you're happy with the wording in the changlog (same as in the description of this PR) |
Contributor
|
|
richardlau
approved these changes
Mar 10, 2022
Member
Looks good to me. I'll submit a suggestion for some typographical changes, but this is fine to land without my suggestions as far as I'm concerned. |
Trott
approved these changes
Mar 10, 2022
Trott
reviewed
Mar 10, 2022
Comment on lines
+53
to
+55
| This release fixes an issue introduced in Node.js v17.7.0 when the url | ||
| has @ characters in it, which showed up when using yarn v1. This version | ||
| reverts the change that introduced the regression. |
Member
There was a problem hiding this comment.
Optional non-blocking suggestion:
Suggested change
| This release fixes an issue introduced in Node.js v17.7.0 when the url | |
| has @ characters in it, which showed up when using yarn v1. This version | |
| reverts the change that introduced the regression. | |
| This release fixes an issue introduced in Node.js v17.7.0 with some URLs | |
| that contain `@`. This issue affected yarn v1. This version reverts the | |
| change that introduced the regression. |
Contributor
|
Maybe it's possible to pull #42205 into it? 🙄 |
Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain `@`. This issue affected yarn 1. This version reverts the change that introduced the regression. PR-URL: #42285
Member
Author
|
Force pushed with both typographical suggestions :-) |
sxa
marked this pull request as ready for review
March 10, 2022 17:50
Member
Author
|
Member
BethGriggs
approved these changes
Mar 10, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Mar 10, 2022
Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain `@`. This issue affected yarn 1. This version reverts the change that introduced the regression. PR-URL: #42285
sxa
added a commit
to sxa/nodejs.org
that referenced
this pull request
Mar 10, 2022
Refs: nodejs/node#42285 Signed-off-by: Stewart X Addison <[email protected]>
BethGriggs
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 10, 2022
Refs: nodejs/node#42285 Signed-off-by: Stewart X Addison <[email protected]>
This was referenced Mar 11, 2022
6 tasks
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain `@`. This issue affected yarn 1. This version reverts the change that introduced the regression. PR-URL: nodejs#42285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022-03-10, Version 17.7.1 (Current), @BethGriggs prepared by @sxa
Notable Changes
Fixed regression in url.resolve()
This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain
@. This issue affected yarn 1. This version reverts the change that introduced the regression.Commits
96a9e00fb3] - url: revert fix url.parse() for@hostname(Antoine du Hamel) #42280