doc: clarify paramater for napi_get_cb_info #41635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
tniessen
approved these changes
Jan 21, 2022
doc/api/n-api.md
Outdated
| receives the actual count of arguments. `argc` can | ||
| optionally be ignored by passing `NULL`. | ||
| * `[out] argv`: Buffer to which the `napi_value` representing the arguments are | ||
| * `[out] argv`: Array of `napi_values` to which the arguments will be |
Member
There was a problem hiding this comment.
Unless napi_values is a real type, it should not be in backticks. This document seems to use this instead:
Suggested change
| * `[out] argv`: Array of `napi_values` to which the arguments will be | |
| * `[out] argv`: Array of `napi_value`s to which the arguments will be |
addaleax
reviewed
Jan 21, 2022
benjamingr
approved these changes
Jan 21, 2022
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
LGTM with the suggestions by Anna and Tobias
NickNaso
approved these changes
Jan 22, 2022
Member
|
paramater -> parameter |
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <[email protected]>
Member
Author
|
squashed and fixed commit comment. |
mhdawson
added a commit
that referenced
this pull request
Jan 25, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41635 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Member
Author
|
Landed in a2dead4 |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41635 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41635 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41635 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41635 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41635 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/help#3698
Signed-off-by: Michael Dawson [email protected]