async_hooks: eliminate require side effects#40782
Merged
Trott merged 1 commit intonodejs:masterfrom Nov 13, 2021
Merged
Conversation
nodejs-github-bot
added
c++
Flarna
approved these changes
Nov 10, 2021
puzpuzpuz
approved these changes
Nov 11, 2021
Member
Member
Author
|
I had a quick look because of that. As far as I can tell this shouldn't trigger that though. I just saw a thing in looking back at the code that could be improved. |
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Flarna
added
the
author ready
35 tasks
JungMinu
approved these changes
Nov 12, 2021
Member
|
Does it make sense to add a test? |
Member
Author
|
Not sure how you'd even test it given that it's functionally identical other than just setting the trampoline function a little later and clearing it if the hooks are disabled. Do we have prior art on testing these environment fields? I guess it'd need to be a native test. In any case, I'll be travelling for the next week so I can either deal with that after I get back or we can land as-is. I'm good either way as it's not really any substantial/important change. |
31 tasks
PR-URL: nodejs#40782 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Trott
force-pushed
the
eliminate-async_hooks-require-side-effects
branch
from
15a34d4 to
689405c
Compare
Member
|
Landed in 689405c |
This was referenced Nov 14, 2021
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
PR-URL: #40782 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40782 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40782 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor improvement to avoid any unintended side effects to requiring async_hooks.
cc @nodejs/async_hooks