Skip to content

deps: update V8 to 9.6#40488

Closed
targos wants to merge 16 commits intonodejs:masterfrom
targos:v8-96
Closed

deps: update V8 to 9.6#40488
targos wants to merge 16 commits intonodejs:masterfrom
targos:v8-96

Conversation

@targos
Copy link
Copy Markdown
Member

@targos targos commented Oct 17, 2021

@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 17, 2021
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 17, 2021
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 17, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40335/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4333/

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2021
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 17, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40336/

@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 17, 2021

@nodejs/platform-windows-arm Can you please help with the build failure on arm64?

I tried to make our GYP config closer to the GN one, but it's still failing

4d1e094
https://ci.nodejs.org/job/node-compile-windows/42438/nodes=win-vs2019-arm64/console

14:25:53      Creating library ..\..\out\Release\mksnapshot_host.lib and object ..\..\out\Release\mksnapshot_host.exp
14:25:59 v8_base_without_compiler_host.lib(api.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::TryHandleWasmTrap(struct _EXCEPTION_POINTERS *)" (?TryHandleWasmTrap@trap_handler@internal@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) referenced in function "bool __cdecl v8::TryHandleWebAssemblyTrapWindows(struct _EXCEPTION_POINTERS *)" (?TryHandleWebAssemblyTrapWindows@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00 v8_base_without_compiler_host.lib(handler-outside.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::RegisterDefaultTrapHandler(void)" (?RegisterDefaultTrapHandler@trap_handler@internal@v8@@YA_NXZ) referenced in function "bool __cdecl v8::internal::trap_handler::EnableTrapHandler(bool)" (?EnableTrapHandler@trap_handler@internal@v8@@YA_N_N@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00 v8_base_without_compiler_host.lib(simulator-arm64.obj) : error LNK2019: unresolved external symbol ProbeMemory referenced in function "protected: void __cdecl v8::internal::Simulator::LoadStoreHelper(class v8::internal::Instruction *,__int64,enum v8::internal::AddrMode)" (?LoadStoreHelper@Simulator@internal@v8@@IEAAXPEAVInstruction@23@_JW4AddrMode@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00     Hint on symbols that are defined and could potentially match:
14:26:00       "protected: bool __cdecl v8::internal::Simulator::ProbeMemory(unsigned __int64,unsigned __int64)" (?ProbeMemory@Simulator@internal@v8@@IEAA_N_K0@Z)
14:26:00 ..\..\out\Release\mksnapshot_host.exe : fatal error LNK1120: 3 unresolved externals [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00

This was referenced Oct 18, 2021
Open
Open
@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 19, 2021

I'm pretty sure the problem is that handler-outside-win.cc' is not being compiled, so something is wrong with the gyp condition.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40360/

@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 19, 2021

I opened a V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=12327

@targos targos marked this pull request as draft October 19, 2021 18:18
@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 19, 2021 •
edited
Loading

Trying a new build which will hopefully log the values of some macros: https://ci.nodejs.org/job/node-test-commit-windows-fanned/44944/

https://ci.nodejs.org/job/node-test-commit-windows-fanned/44945/

https://ci.nodejs.org/job/node-test-commit-windows-fanned/44946/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40373/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40374/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40375/

@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 19, 2021

So, we've got a problem with gyp that I have no idea how to solve:

https://github.com/targos/node/blob/5dae1dba882f6ce71016a7b08f7f120e3015b342/tools/v8_gypfiles/v8.gyp#L871

  • With conditions, _toolset is not defined, because toolsets is defined conditionally (it has to be).
  • With target_conditions, _toolset is defined, but host_arch is not.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40376/

@github-actions github-actions bot mentioned this pull request Oct 20, 2021
Open
27 tasks
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 20, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40379/

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Nov 30, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
732490a 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Nov 30, 2021
@targos
2021-11-30, Version 17.2.0 (Current)
79731df 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) #40760
deps:
  * (SEMVER-MINOR) update V8 to 9.6.180.14 (Michaël Zasso) #40488
lib:
  * (SEMVER-MINOR) add reason to AbortSignal (James M Snell) #40807
src:
  * (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) #39809
stream:
  * deprecate thenable support (Antoine du Hamel) #40860
  * fix finished regression when working with legacy Stream (Matteo Collina) #40858

PR-URL: #40983
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 1, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
a0f1aa1 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 2, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
36ff815 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 3, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
007d90e 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 4, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
1b5393e 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 5, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
ffbbd83 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 6, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
cc3c121 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 7, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
e30493e 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 8, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
fe1fd5d 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 9, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
608234c 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Dec 9, 2021
@targos
deps: disable trap handler for Windows cross-compiler
96b606f 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 10, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
7c9132b 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 11, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
1fb1984 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 12, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
53ea8e6 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 13, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
7b72e5a 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 14, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
d746f30 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Dec 15, 2021
@targos
deps: disable trap handler for Windows cross-compiler
fa86751 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 15, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
f5673e5 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 16, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
1af563a 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 17, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
bac3e4b 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 18, 2021
@targos @nodejs-github-bot
deps: disable trap handler for Windows cross-compiler
f1adfd7 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@hexchain hexchain mentioned this pull request Jan 3, 2022
Closed
@RaisinTen RaisinTen mentioned this pull request May 30, 2022
Closed
@bengl bengl mentioned this pull request May 31, 2022
Merged
This was referenced May 31, 2022
Closed
Merged
@krk krk mentioned this pull request Dec 30, 2022
Closed
This was referenced Jan 28, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos @nodejs-github-bot @jasnell @gengjiawen @BethGriggs @refack @joaocgreis @rayw000