Skip to content

stream: use finished for async iteration #39282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 7 commits into from
Closed

stream: use finished for async iteration #39282

ronag wants to merge 7 commits into from

Conversation

@ronag
Copy link
Member

@ronag ronag commented Jul 5, 2021 •
edited
Loading

Depends on semver-major changes on master.

@github-actions github-actions bot added the needs-ci PRs that need a full CI run. label Jul 5, 2021
@ronag
Copy link
Member Author

ronag commented Jul 5, 2021

@RaisinTen this doesn't pass all test, if you want feel free to have a go at it

ronag
ronag commented Jul 6, 2021
View reviewed changes
ronag
ronag commented Jul 6, 2021
View reviewed changes
@ronag ronag marked this pull request as ready for review July 7, 2021 13:01
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Jul 7, 2021
@ronag ronag requested a review from mcollina July 7, 2021 13:01
@ronag
Copy link
Member Author

ronag commented Jul 7, 2021

@nodejs/streams

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jul 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38890/

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38897/

@ronag
Copy link
Member Author

ronag commented Jul 8, 2021

Landed in ce00381

@ronag ronag closed this Jul 8, 2021
ronag added a commit that referenced this pull request Jul 8, 2021
@ronag
stream: use finished for async iteration
ce00381 
PR-URL: #39282
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ronag @nodejs-github-bot @jasnell @benjamingr